From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:45673)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNYZf-0007xh-6G
	for guix-patches@gnu.org; Mon, 06 May 2019 04:02:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNYZY-00061D-Hk
	for guix-patches@gnu.org; Mon, 06 May 2019 04:02:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42087)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hNYZW-0005zl-EE
	for guix-patches@gnu.org; Mon, 06 May 2019 04:02:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNYZW-00048u-9S
	for guix-patches@gnu.org; Mon, 06 May 2019 04:02:02 -0400
Subject: [bug#35318] [PATCH] Update cargo-build-system to expand package inputs
Resent-Message-ID: <handler.35318.B35318.155712966615854@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <E6292059-4F4A-4360-BF82-CB4674A997E5@gmail.com>
Date: Mon, 06 May 2019 10:00:50 +0200
In-Reply-To: <E6292059-4F4A-4360-BF82-CB4674A997E5@gmail.com> (Ivan Petkov's
	message of "Thu, 18 Apr 2019 22:34:05 -0700")
Message-ID: <87ftpsnhal.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ivan Petkov <ivanppetkov@gmail.com>
Cc: 35318@debbugs.gnu.org, Chris Marusich <cmmarusich@gmail.com>

Hello,

Ivan Petkov <ivanppetkov@gmail.com> skribis:

> From ca6dfd9451f22c4d6dc02aa7eceee0c35800dd57 Mon Sep 17 00:00:00 2001
> From: Ivan Petkov <ivanppetkov@gmail.com>
> Date: Tue, 16 Apr 2019 03:32:44 -0700
> Subject: [PATCH 1/4] packages: allow dynamic input closure computation
>
> * guix/packages: (transitive-inputs): Rename to
> package-transitive-dependencies.
> (package-transitive-dependencies): Add proc parameter and use it.
> (transitive-inputs): Add it.

There=E2=80=99s nothing written in terms of =E2=80=9Cdependencies=E2=80=9D;=
 instead everything
is written in terms of =E2=80=9Cinputs=E2=80=9D, so I=E2=80=99d like to rem=
ain consistent here.

If we need something more specific, I=E2=80=99d rather see it as a private
procedure in (guix build-system cargo-build-system).

Danny wrote:

> It's used in patch 2 in order to consider both inputs and propagated inpu=
ts
> rather than just propagated inputs.

I=E2=80=99m not sure I want to know the details :-), but it seems to be what
=E2=80=98package-transitive-inputs=E2=80=99 does, no?

  (define (package-transitive-inputs package)
    "Return the transitive inputs of PACKAGE---i.e., its direct inputs along
  with their propagated inputs, recursively."
    (transitive-inputs (package-direct-inputs package)))

Do you have an example of a package where this is not enough?

Thanks,
Ludo=E2=80=99.