From: mike@rohleder.de
To: Jack Hill <jackhill@jackhill.us>
Cc: 25201-done@debbugs.gnu.org
Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default.
Date: Tue, 10 Mar 2020 17:03:14 +0100 [thread overview]
Message-ID: <87ftegqjst.fsf_-_@rohleder.de> (raw)
In-Reply-To: <alpine.DEB.2.20.2003101042560.19733@marsh.hcoop.net> (Jack Hill's message of "Tue, 10 Mar 2020 10:50:57 -0400 (EDT)")
[-- Attachment #1: Type: text/plain, Size: 907 bytes --]
Hi Jack,
Jack Hill <jackhill@jackhill.us> writes:
> I'm trying to follow along, and learn some things about making Guix
> packages. One question I have after seeing this change is how did you
> decide whether to make this change in the source definition (with a
> patch or a snippet) or in a phase during the build?
Well, I saw the substitute* of a #include header
(fix-libspeechd-include) in the phase, but the removing of dirs in the
source definition and I thought, ok, it might make more sense this way.
(because, eg, the phase names (fix-libspeechd-include,
fix-statistic-gathering-default etc) could be printed in the log etc)
This decition was more a "it feels better" than knowledge, because I'm
new to guix and scheme and love to learn (by doing) ;)
Regards
mike
--
I have seen the needle and the damage done
and every junkie is like a setting sun.
-- Neil Young
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-03-10 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 18:53 bug#25201: Mumble opts users into statistics gathering by default Thompson, David
2016-12-26 22:42 ` ng0
2020-03-08 17:03 ` bug#25201: [PATCH] gnu: Patch mumble to disable statistic " mike
2020-03-09 10:42 ` Efraim Flashner
2020-03-09 23:54 ` bug#25201: Re " mike
2020-03-10 8:56 ` Efraim Flashner
2020-03-10 14:50 ` Jack Hill
2020-03-10 16:03 ` mike [this message]
2020-03-10 17:14 ` Jack Hill
2020-03-10 18:22 ` bug#25201: Re " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftegqjst.fsf_-_@rohleder.de \
--to=mike@rohleder.de \
--cc=25201-done@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.