all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: mike@rohleder.de
Cc: 25201@debbugs.gnu.org
Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default.
Date: Mon, 9 Mar 2020 12:42:42 +0200	[thread overview]
Message-ID: <20200309104242.GH1423@E5400> (raw)
In-Reply-To: <20200308170316.22591-1-mike@rohleder.de>

[-- Attachment #1: Type: text/plain, Size: 2696 bytes --]

When you add a patch you also need to register it in gnu/local.mk so
when we create tarballs it makes sure that all the files are included.

On the other hand, since it's really only a 1 line change it would
probably be better to do it in the snippet. Can you send a revised
patch? (Or let me know why it should be a patch file :) )


On Sun, Mar 08, 2020 at 06:03:16PM +0100, mike@rohleder.de wrote:
> Fixes <https://bugs.gnu.org/25201>
> ---
>  gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++
>  gnu/packages/telephony.scm                        |  2 ++
>  2 files changed, 15 insertions(+)
>  create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch
> 
> diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/packages/patches/mumble-statistic-25201.patch
> new file mode 100644
> index 0000000000..3cce1826a7
> --- /dev/null
> +++ b/gnu/packages/patches/mumble-statistic-25201.patch
> @@ -0,0 +1,13 @@
> +changed usage statistic gathering defaults to off. See <https://bugs.gnu.org/25201>
> +
> +--- a/src/mumble/Settings.cpp	2020-03-08 15:29:11.897056953 +0100
> ++++ b/src/mumble/Settings.cpp	2020-03-08 14:11:53.600486793 +0100
> +@@ -298,7 +298,7 @@
> + 	bHideInTray = !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvailable();
> + #endif
> + 	bStateInTray = true;
> +-	bUsage = true;
> ++	bUsage = false;
> + 	bShowUserCount = false;
> + 	bChatBarUseSelection = false;
> + 	bFilterHidesEmptyChannels = true;
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index a645c58562..74991079db 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -15,6 +15,7 @@
>  ;;; Copyright © 2019 Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
>  ;;; Copyright © 2019 Ivan Vilata i Balaguer <ivan@selidor.net>
>  ;;; Copyright © 2020 Brett Gilio <brettg@gnu.org>
> +;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -404,6 +405,7 @@ address of one of the participants.")
>                 (base32
>                  "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs"))
>                (modules '((guix build utils)))
> +              (patches (search-patches "mumble-statistic-25201.patch"))
>                (snippet
>                 `(begin
>                    ;; Remove bundled software.  Keep arc4random, celt-0.7.0,
> -- 
> 2.25.1
> 
> 
> 
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-09 10:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 18:53 bug#25201: Mumble opts users into statistics gathering by default Thompson, David
2016-12-26 22:42 ` ng0
2020-03-08 17:03 ` bug#25201: [PATCH] gnu: Patch mumble to disable statistic " mike
2020-03-09 10:42   ` Efraim Flashner [this message]
2020-03-09 23:54     ` bug#25201: Re " mike
2020-03-10  8:56       ` Efraim Flashner
2020-03-10 14:50         ` Jack Hill
2020-03-10 16:03           ` mike
2020-03-10 17:14             ` Jack Hill
2020-03-10 18:22           ` bug#25201: Re " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309104242.GH1423@E5400 \
    --to=efraim@flashner.co.il \
    --cc=25201@debbugs.gnu.org \
    --cc=mike@rohleder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.