From: Mathieu Othacehe <m.othacehe@gmail.com>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40862@debbugs.gnu.org
Subject: [bug#40862] gnu: Add xarchiver.
Date: Sun, 26 Apr 2020 11:22:21 +0200 [thread overview]
Message-ID: <87ftcqfvoy.fsf@gmail.com> (raw)
In-Reply-To: <20200426045129.31f36e15.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Sun, 26 Apr 2020 04:51:29 -0400")
Hello Raghav,
Thanks for this patch. When running 'guix lint' on this patch, I have
the following warnings:
--8<---------------cut here---------------start------------->8---
/home/mathieu/guix-master/gnu/packages/compression.scm:87:5: xarchiver@0.5.4.14: the source file name should contain the package name
/home/mathieu/guix-master/gnu/packages/compression.scm:87:5: xarchiver@0.5.4.14: the source URI should not be an autogenerated tarball
fetching CVE database for 2020......
fetching CVE database for 2019...
fetching CVE database for 2018...
fetching CVE database for 2017...
/home/mathieu/guix-master/gnu/packages/compression.scm:85:13: xarchiver@0.5.4.14: can be upgraded to 0.5b2
--8<---------------cut here---------------end--------------->8---
>
> +(define-public xarchiver
> + (package
> + (name "xarchiver")
> + (version "0.5.4.14")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + (string-append "https://github.com/ib/" name "/archive/"
> + version ".tar.gz"))
You should use "git-fetch" method for github repositories (see linter
warning above).
> + (list
> + "--disable-plugin"))) ; Not required
Why is it not required?
> + (synopsis "Graphical Front-end for Archive Operations")
No camel case notation.
> + (description "Xarchiver is the ultimate solution for handling archives. It
> +is a desktop-environment independent archiver front end.")
"Ultimate" is maybe exaggerated! Also you could elaborate a bit on the
functionalities of this tool.
Thanks,
Mathieu
next prev parent reply other threads:[~2020-04-26 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 8:51 [bug#40862] gnu: Add xarchiver Raghav Gururajan
2020-04-26 9:22 ` Mathieu Othacehe [this message]
2020-04-26 9:53 ` [bug#40862] gnu: Add xarchiver. (v2) Raghav Gururajan
2020-04-26 10:29 ` Mathieu Othacehe
2020-04-26 10:29 ` bug#40862: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftcqfvoy.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=40862@debbugs.gnu.org \
--cc=raghavgururajan@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.