From: Raghav Gururajan <raghavgururajan@disroot.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40862@debbugs.gnu.org
Subject: [bug#40862] gnu: Add xarchiver. (v2)
Date: Sun, 26 Apr 2020 05:53:05 -0400 [thread overview]
Message-ID: <20200426055305.4bb9fc0f.raghavgururajan@disroot.org> (raw)
In-Reply-To: <87ftcqfvoy.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]
Hello Mathieu!
> Thanks for this patch. When running 'guix lint' on this patch, I have
> the following warnings:
>
> --8<---------------cut here---------------start------------->8---
> /home/mathieu/guix-master/gnu/packages/compression.scm:87:5:
> xarchiver@0.5.4.14: the source file name should contain the package name
> /home/mathieu/guix-master/gnu/packages/compression.scm:87:5:
> xarchiver@0.5.4.14: the source URI should not be an autogenerated tarball
> fetching CVE database for 2020...... fetching CVE database for 2019...
> fetching CVE database for 2018... fetching CVE database for 2017...
> /home/mathieu/guix-master/gnu/packages/compression.scm:85:13:
> xarchiver@0.5.4.14: can be upgraded to 0.5b2 --8<---------------cut
> here---------------end--------------->8---
>
> >
> > +(define-public xarchiver
> > + (package
> > + (name "xarchiver")
> > + (version "0.5.4.14")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri
> > + (string-append "https://github.com/ib/" name "/archive/"
> > + version ".tar.gz"))
>
> You should use "git-fetch" method for github repositories (see linter
> warning above).
>
> > + (list
> > + "--disable-plugin"))) ; Not required
>
> Why is it not required?
>
> > + (synopsis "Graphical Front-end for Archive Operations")
>
> No camel case notation.
>
> > + (description "Xarchiver is the ultimate solution for handling
> > archives. It +is a desktop-environment independent archiver front end.")
>
> "Ultimate" is maybe exaggerated! Also you could elaborate a bit on the
> functionalities of this tool.
Please find the revised patch attached with this email.
Regards,
RG.
[-- Attachment #2: 0001-gnu-Add-xarchiver.patch --]
[-- Type: text/x-patch, Size: 2744 bytes --]
From 23e7dc347108c75f92d5bafd17b39cba47eed486 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 26 Apr 2020 05:50:47 -0400
Subject: [PATCH] gnu: Add xarchiver.
* gnu/packages/compression (xarchiver): New variable.
---
gnu/packages/compression.scm | 38 ++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index e9ef302bcd..7333810c73 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -50,6 +50,7 @@
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module (guix build-system cmake)
+ #:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system python)
#:use-module (guix build-system trivial)
@@ -63,6 +64,10 @@
#:use-module (gnu packages curl)
#:use-module (gnu packages documentation)
#:use-module (gnu packages file)
+ #:use-module (gnu packages gettext)
+ #:use-module (gnu packages glib)
+ #:use-module (gnu packages gnome)
+ #:use-module (gnu packages gtk)
#:use-module (gnu packages maths)
#:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
@@ -70,9 +75,42 @@
#:use-module (gnu packages qt)
#:use-module (gnu packages tls)
#:use-module (gnu packages valgrind)
+ #:use-module (gnu packages xml)
#:use-module (ice-9 match)
#:use-module ((srfi srfi-1) #:select (last)))
+(define-public xarchiver
+ (package
+ (name "xarchiver")
+ (version "0.5.4.14")
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/ib/xarchiver.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "1iklwgykgymrwcc5p1cdbh91v0ih1m58s3w9ndl5kyd44bwlb7px"))))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("intltool" ,intltool)
+ ("libxslt" ,libxslt)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("adwaita-icon-theme" ,adwaita-icon-theme) ; Hard-coded theme
+ ("gtk+" ,gtk+)))
+ (synopsis "Graphical front-end for archive operations")
+ (description "Xarchiver is a front-end to various command line archiving
+tools. It uses GTK+ tool-kit and is designed to be desktop-environment
+independent. Supported formats are 7z, ARJ, bzip2, gzip, LHA, lzma, lzop, RAR,
+RPM, DEB, tar, and ZIP. It cannot perform functions for archives, whose
+archiver is not installed.")
+ (home-page "https://github.com/ib/xarchiver")
+ (license license:gpl2+)))
+
(define-public zlib
(package
(name "zlib")
--
2.26.2
next prev parent reply other threads:[~2020-04-26 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 8:51 [bug#40862] gnu: Add xarchiver Raghav Gururajan
2020-04-26 9:22 ` Mathieu Othacehe
2020-04-26 9:53 ` Raghav Gururajan [this message]
2020-04-26 10:29 ` [bug#40862] gnu: Add xarchiver. (v2) Mathieu Othacehe
2020-04-26 10:29 ` bug#40862: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200426055305.4bb9fc0f.raghavgururajan@disroot.org \
--to=raghavgururajan@disroot.org \
--cc=40862@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.