From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Morgan.J.Smith@outlook.com
Cc: 42216@debbugs.gnu.org
Subject: [bug#42216] [PATCH] gnu: Add emacs-flycheck-ledger.
Date: Mon, 06 Jul 2020 14:24:47 +0200 [thread overview]
Message-ID: <87fta47rw0.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <DM5PR1001MB2105D585E38C8C158A3490E6C5680@DM5PR1001MB2105.namprd10.prod.outlook.com> (Morgan J. Smith's message of "Sun, 5 Jul 2020 14:20:23 -0400")
Hello,
Morgan.J.Smith@outlook.com writes:
> * gnu/packages/emacs-xyz.scm (emacs-flycheck-ledger): New variable.
Thank you. Some comments follow.
> +(define-public emacs-flycheck-ledger
> + (package
> + (name "emacs-flycheck-ledger")
> + (version "20200304.2204")
There's a stable "0.5" release. We should use it instead.
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/flycheck-ledger-"
> + version ".el"))
We don't use source files from MELPA, as they are somewhat modified
in-place. Use git-fetch instead.
Also, could you move `origin' behind `source'?
> + (sha256
> + (base32
> + "036xn52xjxbbvag9slqi4xqlvzg9p2q544hhxhqqi7jz1kap0yx8"))))
> + (inputs `(("ledger" ,ledger)))
I think this is not sufficient, because Emacs Flycheck Ledger will not
find the Ledger executable. You need to tweak
`flycheck-ledger-executable', using `emacs-substitute-variables'.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-07-06 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 18:20 [bug#42216] [PATCH] gnu: Add emacs-flycheck-ledger Morgan.J.Smith
2020-07-06 12:24 ` Nicolas Goaziou [this message]
2020-07-11 1:34 ` Morgan.J.Smith
2020-07-14 9:13 ` bug#42216: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fta47rw0.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=42216@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.