From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GNGMAiQYA189GgAA0tVLHw (envelope-from ) for ; Mon, 06 Jul 2020 12:25:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +F3UOSMYA1+jCAAAbx9fmQ (envelope-from ) for ; Mon, 06 Jul 2020 12:25:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 760D69400B7 for ; Mon, 6 Jul 2020 12:25:07 +0000 (UTC) Received: from localhost ([::1]:50352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsQBG-0004cD-E8 for larch@yhetil.org; Mon, 06 Jul 2020 08:25:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsQBD-0004c4-48 for guix-patches@gnu.org; Mon, 06 Jul 2020 08:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jsQBC-0001aH-N6 for guix-patches@gnu.org; Mon, 06 Jul 2020 08:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jsQBC-0004q6-I9 for guix-patches@gnu.org; Mon, 06 Jul 2020 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42216] [PATCH] gnu: Add emacs-flycheck-ledger. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Jul 2020 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42216 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan.J.Smith@outlook.com Cc: 42216@debbugs.gnu.org Received: via spool by 42216-submit@debbugs.gnu.org id=B42216.159403829718584 (code B ref 42216); Mon, 06 Jul 2020 12:25:02 +0000 Received: (at 42216) by debbugs.gnu.org; 6 Jul 2020 12:24:57 +0000 Received: from localhost ([127.0.0.1]:33727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsQB7-0004pg-4H for submit@debbugs.gnu.org; Mon, 06 Jul 2020 08:24:57 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:45783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsQB5-0004pR-4T for 42216@debbugs.gnu.org; Mon, 06 Jul 2020 08:24:56 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 5F10BC0006; Mon, 6 Jul 2020 12:24:48 +0000 (UTC) From: Nicolas Goaziou References: Date: Mon, 06 Jul 2020 14:24:47 +0200 In-Reply-To: (Morgan J. Smith's message of "Sun, 5 Jul 2020 14:20:23 -0400") Message-ID: <87fta47rw0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: IWTKbqXJsn1L Hello, Morgan.J.Smith@outlook.com writes: > * gnu/packages/emacs-xyz.scm (emacs-flycheck-ledger): New variable. Thank you. Some comments follow. > +(define-public emacs-flycheck-ledger > + (package > + (name "emacs-flycheck-ledger") > + (version "20200304.2204") There's a stable "0.5" release. We should use it instead. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://melpa.org/packages/flycheck-ledger-" > + version ".el")) We don't use source files from MELPA, as they are somewhat modified in-place. Use git-fetch instead. Also, could you move `origin' behind `source'? > + (sha256 > + (base32 > + "036xn52xjxbbvag9slqi4xqlvzg9p2q544hhxhqqi7jz1kap0yx8")))) > + (inputs `(("ledger" ,ledger))) I think this is not sufficient, because Emacs Flycheck Ledger will not find the Ledger executable. You need to tweak `flycheck-ledger-executable', using `emacs-substitute-variables'. Could you send an updated patch? Regards, -- Nicolas Goaziou