From: Vinicius Monego <monego@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 48226@debbugs.gnu.org
Subject: [bug#48226] [PATCH] gnu: pre-commit: Update to 2.12.1.
Date: Wed, 12 May 2021 06:45:52 +0000 [thread overview]
Message-ID: <87fsysjvq7.fsf@posteo.net> (raw)
In-Reply-To: <87cztx36mg.fsf@gnu.org>
Ludovic Courtès writes:
> Hi,
>
> Vinicius Monego <monego@posteo.net> skribis:
>
>> * gnu/packages/version-control.scm (pre-commit): Update to 2.12.1.
>> [arguments]: Simplify running tests. Make source tree writable and initialize
>> a git repositoryy before check phase.
>> [native-inputs]: Add python-covdefaults, python-coverage, python-distlib/next,
>> python-pytest-env, which. Use git instead of git-minimal.
>
> What’s the reason to depend on ‘git’ rather than ‘git-minimal’? (We
> usually avoid that so packages don’t pull more than needed.)
Hi Ludo,
I thought -minimal packages were there for internal use such as solving
bootstrapping issues. Full git is also more common as input in
gnu/packages. Pre-commit builds just fine with git-minimal though.
I sent a v2 without changing git-minimal and fixed the commit message.
>
> Apart from that it LGTM.
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2021-05-12 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 13:44 [bug#48226] [PATCH] gnu: pre-commit: Update to 2.12.1 Vinicius Monego
2021-05-11 10:30 ` Ludovic Courtès
2021-05-12 6:45 ` Vinicius Monego [this message]
2021-05-12 6:39 ` [bug#48226] [PATCH v2] " Vinicius Monego
2021-05-12 22:21 ` bug#48226: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsysjvq7.fsf@posteo.net \
--to=monego@posteo.net \
--cc=48226@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.