From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0edsKR56m2CI1gAAgWs5BA (envelope-from ) for ; Wed, 12 May 2021 08:47:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0G55JB56m2DXKQAAB5/wlQ (envelope-from ) for ; Wed, 12 May 2021 06:47:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6375D23A61 for ; Wed, 12 May 2021 08:47:58 +0200 (CEST) Received: from localhost ([::1]:39058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgiez-0000bX-Gy for larch@yhetil.org; Wed, 12 May 2021 02:47:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgieC-0000De-UF for guix-patches@gnu.org; Wed, 12 May 2021 02:47:10 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54683) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgie5-0007to-TD for guix-patches@gnu.org; Wed, 12 May 2021 02:47:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgie5-0006iM-P8 for guix-patches@gnu.org; Wed, 12 May 2021 02:47:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48226] [PATCH] gnu: pre-commit: Update to 2.12.1. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 May 2021 06:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48226 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 48226@debbugs.gnu.org Received: via spool by 48226-submit@debbugs.gnu.org id=B48226.162080201825801 (code B ref 48226); Wed, 12 May 2021 06:47:01 +0000 Received: (at 48226) by debbugs.gnu.org; 12 May 2021 06:46:58 +0000 Received: from localhost ([127.0.0.1]:37996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgie2-0006i5-ER for submit@debbugs.gnu.org; Wed, 12 May 2021 02:46:58 -0400 Received: from mout01.posteo.de ([185.67.36.65]:57287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgie0-0006hq-EB for 48226@debbugs.gnu.org; Wed, 12 May 2021 02:46:56 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 297B324002A for <48226@debbugs.gnu.org>; Wed, 12 May 2021 08:46:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1620802010; bh=JvKjuDAyjGnXUU+JfSFepyFT5+tVHNzfcd8bqO2Pdj8=; h=From:To:Cc:Subject:Date:From; b=Qbbv+p0JfLL9bGfvVXwkrIYaStamD8PJ9jc36w4f8l6rH+PpUHIG3FAmMEdwcjSW/ KCDy2FTOL7dlNflY3i/Fr91bmtq4FFbUQfpsxf5nbSk1gTU069X3XZOcieENtF07C1 nVXyVFTeUiiHLm4yW707OlpwE3igZcTqnTZ+VYB0eX3dOWCQriQTxJjxkJmLObJGd1 JDkXJQJJ/uqOc3QwK+SUX7y/Adry6zqqVrf50i3FPoGi9FB39vF6jfrR1n9D2uluCp Zj1+OSuT+aMa3ay7ZbMFfN/f79XfJBHaRA2XEiQOutorGjVJ+xKPKTylm4SupsxJCE tTaWU0fJXRfCA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Fg51M2STGz9rxg; Wed, 12 May 2021 08:46:46 +0200 (CEST) References: <20210504134428.331526-1-monego@posteo.net> <87cztx36mg.fsf@gnu.org> From: Vinicius Monego In-reply-to: <87cztx36mg.fsf@gnu.org> Date: Wed, 12 May 2021 06:45:52 +0000 Message-ID: <87fsysjvq7.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620802078; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=L7eD1bI1fANfZQtkCf9+1gqmF3doJB6I0wRINUaFGis=; b=C9zMmguEBg7uHVIbeCtxhLfiGDHCyS2Xp/Y1NPhfodS8rjlbGDlnNw8ZhsCX+Z8Gb1epEe Z3TWb1MWkoWphRNUjcFQH02izviEIJTCNpVCxZ+r9J9FbFU9tUecfvawyMOL25mOc49Ra/ LRRkaiLS6X8LJbuahbeDxh+j/47R9YG9FJ6y6sy1YxyEt/CQHL/Xyi4nr9zEvNZJsGfAt5 fPial0lzxc1PujWbGelb4QyWpPYOls8+MoqjxbyWPZ5QRnGyxwTyd1XEqgqMB+KBvC+lkE BwUf+mlL8YMhCDKGe8eH/9xRSNq7BylXc7nVgMUgFTagke/s090FCGVjzGx0lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620802078; a=rsa-sha256; cv=none; b=A8hLIphWyT4ol69A8gGAv8STfnz/FsQfxna2BFi5cKNn813cMPYgM0cxOJ4hmTEh+LypOS 98HAUMEkis10Vap21ks8HIVKFGptcYMUsmH69TxaLMy8CiRpp/lR+ElbObAh8uzX1DWwqM yBlknbANqwFVSB4p7rqjQQpYspnT3liirFVgFdnWkvHpQqHEZWkjbldqXbiiiOgKDrvE53 NyTGb9UCOsW08TdV7zJH324WmH+kNHOEiHSlc/vWIGGwfOuI5WWnoX6cycoB6aErmbImH4 4Lb3EOGeNk+H6hLOnClIPTlqUp+8m0js2XlVVmiwkgwXCwR7RES25Dnblu70Ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Qbbv+p0J; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Qbbv+p0J; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6375D23A61 X-Spam-Score: 0.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: a1+CXLy+IoKU Ludovic Court=C3=A8s writes: > Hi, > > Vinicius Monego skribis: > >> * gnu/packages/version-control.scm (pre-commit): Update to 2.12.1. >> [arguments]: Simplify running tests. Make source tree writable and initi= alize >> a git repositoryy before check phase. >> [native-inputs]: Add python-covdefaults, python-coverage, python-distlib= /next, >> python-pytest-env, which. Use git instead of git-minimal. > > What=E2=80=99s the reason to depend on =E2=80=98git=E2=80=99 rather than = =E2=80=98git-minimal=E2=80=99? (We > usually avoid that so packages don=E2=80=99t pull more than needed.) Hi Ludo, I thought -minimal packages were there for internal use such as solving bootstrapping issues. Full git is also more common as input in gnu/packages. Pre-commit builds just fine with git-minimal though. I sent a v2 without changing git-minimal and fixed the commit message. > > Apart from that it LGTM. > > Thanks, > Ludo=E2=80=99.