all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 58386@debbugs.gnu.org
Subject: [bug#58386] [PATCH 2/2] gnu: Add passage.
Date: Sun, 09 Oct 2022 01:05:44 +0200	[thread overview]
Message-ID: <87fsfxdfwk.fsf@nckx> (raw)
In-Reply-To: <20221008224453.8634-2-ngraves@ngraves.fr>

[-- Attachment #1: Type: text/plain, Size: 2153 bytes --]

Heyo,

Nicolas Graves via Guix-patches via 写道:
> +(define-public passage

Thanks!

Most points below can be fixed up by a committer, including the 
description, but those tend to sound better when written by an 
actual user.  If you'd like to give it a try.

> +    (build-system copy-build-system)
> +    (propagated-inputs
> +     (list util-linux git qrencode sed tree age))

Super-nitpick: inputs conventionally hang out a bit lower, under 
the arguments field.

> +    (build-system copy-build-system)

Duped.

> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'rename-exe

s/exe/script/ (or sure, executable).

> +                    (lambda _
> +                      (rename-file "src/password-store.sh"
> +                                   "src/passage"))))
> +       #:install-plan
> +       (list '("src/passage" "/bin/")
> +             '("src/completion/pass.bash-completion"
> +               "/share/bash-completion/completions/")

OK, I've been looking at this for an embarrasingly long time 
trying to figure out what you're trying to communicate with '(… 
(list '(…))).  It seems very deliberate.  Any hints?  :-p

> +    (home-page "https://github.com/FiloSottile/passage")
> +    (synopsis "A fork of the password-store encrypted password 
> manager")

Another nitpic^Wcool tip: @command{} & friends work here just as 
well as in the description.  There's no difference.

The text should describe the package, not its ancestry.

> +    (description "This package provides a fork of the 
> @code{password-store}
> +encrypted password manager.  It relies on @code{age} instead of
> +@code{gnupg}.")

Same here.  I know all of these words but what do they mean?

> +    (license license:gpl2+)))

Checked.

> +
>  (define-public pass-otp
>    (package
>      (name "pass-otp")

> I've made the choice to rename the existing passage game to
> passage-game in a first commit, I hope it's OK. 

No, I don't think it is.  Adding this script need not affect other 
packages.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-10-09  0:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08 22:42 [bug#58386] Age encryption : passage Nicolas Graves via Guix-patches via
2022-10-08 22:44 ` [bug#58386] [PATCH 1/2] gnu: passage: Rename package to passage-game Nicolas Graves via Guix-patches via
2022-10-08 22:44   ` [bug#58386] [PATCH 2/2] gnu: Add passage Nicolas Graves via Guix-patches via
2022-10-08 23:05     ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2022-10-11 21:39       ` [bug#58386] [PATCH v2] " Nicolas Graves via Guix-patches via
2022-10-19 17:17         ` bug#58340: " Tobias Geerinckx-Rice via Guix-patches via
2022-10-19 19:49           ` [bug#58340] bug#58386: " Tobias Geerinckx-Rice via Guix-patches via
2022-10-22  7:51             ` Nicolas Graves via Guix-patches via
2022-10-19 19:54         ` bug#58457: " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsfxdfwk.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=58386@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.