* [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
@ 2023-04-28 21:25 Brian Cully via Guix-patches via
2023-04-28 21:28 ` Brian Cully via Guix-patches via
2023-04-30 21:16 ` bug#63159: " Ludovic Courtès
0 siblings, 2 replies; 3+ messages in thread
From: Brian Cully via Guix-patches via @ 2023-04-28 21:25 UTC (permalink / raw)
To: 63159; +Cc: Brian Cully
GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
negative value, which is impossible. Instead, check for NULL, which is how the
error result is actually returned.
See https://github.com/iwamatsu/slim/issues/14 for details.
* gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
phase
---
gnu/packages/display-managers.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index b0d388f1bc..c1a08e8553 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -475,7 +475,11 @@ (define-public slim
;; The build system's logic here is: if "Linux", then
;; "systemd". Strip that.
""))
- #t)))
+ #t))
+ (add-before 'configure 'fix-0-pointer-comparison
+ (lambda _
+ (substitute* "panel.cpp"
+ (("WinGC < 0") "WinGC == NULL")))))
#:configure-flags '("-DUSE_PAM=yes"
"-DUSE_CONSOLEKIT=no")
#:tests? #f))
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
2023-04-28 21:25 [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 Brian Cully via Guix-patches via
@ 2023-04-28 21:28 ` Brian Cully via Guix-patches via
2023-04-30 21:16 ` bug#63159: " Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Brian Cully via Guix-patches via @ 2023-04-28 21:28 UTC (permalink / raw)
To: 63159
This patch fixes #63155
-bjc
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#63159: [PATCH 1/2] gnu: slim: Fix build failure with GCC-11
2023-04-28 21:25 [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 Brian Cully via Guix-patches via
2023-04-28 21:28 ` Brian Cully via Guix-patches via
@ 2023-04-30 21:16 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2023-04-30 21:16 UTC (permalink / raw)
To: Brian Cully; +Cc: 63159-done, 63155-done
Hi,
Brian Cully <bjc@spork.org> skribis:
> GCC-11 sniffed out a long-standing bug where a pointer was being tested for a
> negative value, which is impossible. Instead, check for NULL, which is how the
> error result is actually returned.
>
> See https://github.com/iwamatsu/slim/issues/14 for details.
>
> * gnu/packages/display-managers.scm (slim) [fix-0-pointer-comparison]: new
> phase
[...]
> Moved to github, according to https://www.berlios.de/software/slim/.
>
> * gnu/packages/display-managers.scm (slim) [home-page]: update URL.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-01 1:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-28 21:25 [bug#63159] [PATCH 1/2] gnu: slim: Fix build failure with GCC-11 Brian Cully via Guix-patches via
2023-04-28 21:28 ` Brian Cully via Guix-patches via
2023-04-30 21:16 ` bug#63159: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.