From: Simon Tournier <zimon.toutoune@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>,
Bruno Victal <mirai@makinata.eu>
Cc: 62754@debbugs.gnu.org, ivan-p-sokolov@ya.ru
Subject: [bug#62754] [PATCH v2] doc: Use G-Expressions for package definition example.
Date: Fri, 05 May 2023 16:06:02 +0200 [thread overview]
Message-ID: <87fs8a7u0l.fsf@gmail.com> (raw)
In-Reply-To: <87edod63xd.fsf@nicolasgoaziou.fr>
Hi,
On ven., 21 avril 2023 at 10:21, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>> The new phase that is inserted is written as an anonymous procedure,
>> -introduced with @code{lambda*}; it honors the @code{outputs} parameter
>> -we have seen before. @xref{Build Utilities}, for more about the helpers
>> -used by this phase, and for more examples of @code{modify-phases}.
>> +introduced with @code{lambda*}. @xref{Build Utilities}, for more about
>> +the helpers used by this phase, and for more examples of
>> +@code{modify-phases}.
>
> I think it still makes sense to refer to `inputs'; it could be
> unsettling otherwise. Maybe something along those lines:
>
> ... introduced with @code{lambda*}; it looks for the @file{xmllint}
> executable in a @file{"/bin"} directory among package's inputs
> (@pxref{package Reference}). It also honors the @code{outputs}
> parameter we have seen before@xref{Build Utilities}, for more...
This tweak looks better to me. Well, Bruno could you send a v3? Or
Nicolas, could you amend the patch and directly apply it?
(Note the typo in « before@xref{Build Utilities} », I guess.)
Cheers,
simon
next prev parent reply other threads:[~2023-05-05 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 15:13 [bug#62754] [PATCH] doc: Use G-Expressions for package definition example Bruno Victal
2023-04-10 19:00 ` Ivan Sokolov
2023-04-11 12:19 ` [bug#62754] [PATCH v2] " Bruno Victal
2023-04-21 8:21 ` Nicolas Goaziou
2023-05-05 14:06 ` Simon Tournier [this message]
2023-05-06 14:19 ` [bug#62754] [PATCH v3] " Bruno Victal
2023-05-06 16:08 ` bug#62754: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs8a7u0l.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=62754@debbugs.gnu.org \
--cc=ivan-p-sokolov@ya.ru \
--cc=mail@nicolasgoaziou.fr \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.