From: "Ludovic Courtès" <ludo@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 64106@debbugs.gnu.org, David Wilson <david@daviwil.com>
Subject: bug#64106: `modify-services` no longer affects multiple instances of the same service
Date: Mon, 19 Jun 2023 09:34:28 +0200 [thread overview]
Message-ID: <87fs6ndhx7.fsf@gnu.org> (raw)
In-Reply-To: <878rci5bpq.fsf@jpoiret.xyz> (Josselin Poiret's message of "Sat, 17 Jun 2023 17:51:13 +0200")
Hi,
Josselin Poiret <dev@jpoiret.xyz> skribis:
> "David Wilson" <david@daviwil.com> writes:
>
>> Hi Guix!
>>
>> Recently there was a change to the behavior of `modify-services` that adds logic to check for any unused clauses so that an exception can be raised to alert the user of this case.
>>
>> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=181951207339508789b28ba7cb914f983319920f
>>
>> It seems that the new logic has a bug that prevents a used clause from being executed on more than one instance of a compatible service in a single execution of `modify-services`. Here's a new test case for `gnu/tests/services.scm` that exhibits the issue:
>
> This was intended, but was probably not a good idea.
It wasn’t really intended, more a side effect of the implementation, and
I agree it should be fixed.
Ludo’.
next prev parent reply other threads:[~2023-06-19 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 12:52 bug#64106: `modify-services` no longer affects multiple instances of the same service David Wilson
2023-06-17 15:51 ` Josselin Poiret via Bug reports for GNU Guix
2023-06-19 7:34 ` Ludovic Courtès [this message]
2023-06-21 18:10 ` Brian Cully via Bug reports for GNU Guix
2023-07-07 14:11 ` Ludovic Courtès
2023-07-18 12:28 ` Brian Cully via Bug reports for GNU Guix
2023-06-26 19:22 ` bug#64106: [PATCH] In modify-services, delete multiple services with one stanza. (Closes: #63921, #64106) Felix Lechner via Bug reports for GNU Guix
2023-07-17 17:02 ` bug#64106: [PATCH] gnu: services: Revert to deleting and updating all matching services Brian Cully via Bug reports for GNU Guix
2023-09-01 3:49 ` bug#65184: (modify-services … (delete …)) should delete all matching service types Maxim Cournoyer
2023-09-01 4:00 ` bug#64106: " Felix Lechner via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs6ndhx7.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=64106@debbugs.gnu.org \
--cc=david@daviwil.com \
--cc=dev@jpoiret.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.