all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brian Cully via Bug reports for GNU Guix <bug-guix@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
	David Wilson <david@daviwil.com>,
	64106@debbugs.gnu.org
Subject: bug#64106: `modify-services` no longer affects multiple instances of the same service
Date: Tue, 18 Jul 2023 08:28:35 -0400	[thread overview]
Message-ID: <878rbd1k0c.fsf@psyduck.jhoto.kublai.com> (raw)
In-Reply-To: <878rbrke00.fsf@gnu.org> ("Ludovic Courtès"'s message of "Fri, 07 Jul 2023 16:11:43 +0200")

I sent a patch to this ticket yesterday, before remembering this morning
that y'all probably weren't auto-Cc'd on it by debbugs.

Please have a look over it, especially the tests, in case I missed some
functionality or misinterpreted some requirements.

This will probably be deserving of a news item, since it will cause
multiple deletes on the same service type to fail, and that's what at
least some people are doing due to the previous patch.

One option would be to convert the ‘raise’ incantations to warnings, at
least for a while to give people a chance to update without their
configs breaking, but I don't know a good way to do that.

-bjc




  reply	other threads:[~2023-07-18 12:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16 12:52 bug#64106: `modify-services` no longer affects multiple instances of the same service David Wilson
2023-06-17 15:51 ` Josselin Poiret via Bug reports for GNU Guix
2023-06-19  7:34   ` Ludovic Courtès
2023-06-21 18:10     ` Brian Cully via Bug reports for GNU Guix
2023-07-07 14:11       ` Ludovic Courtès
2023-07-18 12:28         ` Brian Cully via Bug reports for GNU Guix [this message]
2023-06-26 19:22 ` bug#64106: [PATCH] In modify-services, delete multiple services with one stanza. (Closes: #63921, #64106) Felix Lechner via Bug reports for GNU Guix
2023-07-17 17:02 ` bug#64106: [PATCH] gnu: services: Revert to deleting and updating all matching services Brian Cully via Bug reports for GNU Guix
2023-09-01  3:49   ` bug#65184: (modify-services … (delete …)) should delete all matching service types Maxim Cournoyer
2023-09-01  4:00     ` bug#64106: " Felix Lechner via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rbd1k0c.fsf@psyduck.jhoto.kublai.com \
    --to=bug-guix@gnu.org \
    --cc=64106@debbugs.gnu.org \
    --cc=bjc@spork.org \
    --cc=david@daviwil.com \
    --cc=dev@jpoiret.xyz \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.