all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Vong <alexvong1995@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: alexvong1995@gmail.com, 30598@debbugs.gnu.org
Subject: [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer.
Date: Tue, 27 Feb 2018 03:30:18 +0800	[thread overview]
Message-ID: <87efl74khh.fsf@gmail.com> (raw)
In-Reply-To: <87k1v0woiv.fsf@fastmail.com> (Marius Bakke's message of "Mon, 26 Feb 2018 02:03:20 +0100")

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Alex Vong <alexvong1995@gmail.com> writes:
>
>> Tags: patch
>>
>> Hello,
>>
>> This patch series adds youtube-viewer and its dependencies. It can be
>> used for searching youtube videos without running javascript. It also
>> plays nice with tor which is a plus.
>
> Thanks for this series!  The patches LGTM, but can you move the perl
> packages to gtk.scm and glib.scm respectively?  That seems more
> appropriate, as we already have e.g. pygtk in gtk.scm, and also avoids
> some top-module cross-references.
>
> (Additionally, perl.scm is huge, so it's good to spread the load to
> appease the Guile compiler)
>
> Thanks in advance! :-)

(I messed up my mail settings, so I am re-sending.)

The next patch series should fix everything you've mentioned so far. I
don't understand why wrap-program is used before but now I do.

Thanks for your review also!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2018-02-26 19:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 23:27 [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer Alex Vong
2018-02-24 23:30 ` [bug#30598] [PATCH 1/5] gnu: Add perl-cairo Alex Vong
2018-02-24 23:31 ` [bug#30598] [PATCH 2/5] gnu: Add perl-glib Alex Vong
2018-02-24 23:32 ` [bug#30598] [PATCH 3/5] gnu: Add perl-pango Alex Vong
2018-02-24 23:33 ` [bug#30598] [PATCH 4/5] gnu: Add perl-gtk2 Alex Vong
2018-02-24 23:33 ` [bug#30598] [PATCH 5/5] gnu: Add youtube-viewer Alex Vong
2018-02-26  0:58   ` Marius Bakke
2018-02-26  1:03 ` [bug#30598] [PATCH 0/5] " Marius Bakke
2018-02-26 19:30   ` Alex Vong [this message]
2018-02-28 16:07     ` bug#30598: " Marius Bakke
2018-02-26 18:49 ` [bug#30598] [PATCH 1/5] gnu: Add perl-cairo Alex Vong
2018-02-26 18:49 ` [bug#30598] [PATCH 2/5] gnu: Add perl-glib Alex Vong
2018-02-26 18:50 ` [bug#30598] [PATCH 3/5] gnu: Add perl-pango Alex Vong
2018-02-26 18:51 ` [bug#30598] [PATCH 4/5] gnu: Add perl-gtk2 Alex Vong
2018-02-26 18:51 ` [bug#30598] [PATCH 5/5] gnu: Add youtube-viewer Alex Vong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efl74khh.fsf@gmail.com \
    --to=alexvong1995@gmail.com \
    --cc=30598@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.