From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqOUN-0000hi-NA for guix-patches@gnu.org; Mon, 26 Feb 2018 14:31:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqOUI-0006rt-Q0 for guix-patches@gnu.org; Mon, 26 Feb 2018 14:31:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54255) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqOUI-0006rl-Lb for guix-patches@gnu.org; Mon, 26 Feb 2018 14:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eqOUI-0002dO-Fn for guix-patches@gnu.org; Mon, 26 Feb 2018 14:31:02 -0500 Subject: [bug#30598] [PATCH 0/5] gnu: Add youtube-viewer. Resent-Message-ID: From: Alex Vong References: <87sh9qvuhz.fsf@gmail.com> <87k1v0woiv.fsf@fastmail.com> Date: Tue, 27 Feb 2018 03:30:18 +0800 In-Reply-To: <87k1v0woiv.fsf@fastmail.com> (Marius Bakke's message of "Mon, 26 Feb 2018 02:03:20 +0100") Message-ID: <87efl74khh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: alexvong1995@gmail.com, 30598@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Alex Vong writes: > >> Tags: patch >> >> Hello, >> >> This patch series adds youtube-viewer and its dependencies. It can be >> used for searching youtube videos without running javascript. It also >> plays nice with tor which is a plus. > > Thanks for this series! The patches LGTM, but can you move the perl > packages to gtk.scm and glib.scm respectively? That seems more > appropriate, as we already have e.g. pygtk in gtk.scm, and also avoids > some top-module cross-references. > > (Additionally, perl.scm is huge, so it's good to spread the load to > appease the Guile compiler) > > Thanks in advance! :-) (I messed up my mail settings, so I am re-sending.) The next patch series should fix everything you've mentioned so far. I don't understand why wrap-program is used before but now I do. Thanks for your review also! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTdXC2pN4kXBjiMDs8cGaIXrbrArQUCWpRgSgAKCRAcGaIXrbrA rckoAPoDrfLONE6Smi2Rs0AV0OMNCo2GwHVlDk+h/+aMP9JQmQD+K4mB79HkBMrf TBHxERlj23d4wb8UYpXAo3F3uew86gY= =GMZe -----END PGP SIGNATURE----- --=-=-=--