all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33575@debbugs.gnu.org, 宋文武 <iyzsong@member.fsf.org>
Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted.
Date: Sun, 09 Dec 2018 17:49:45 -0500	[thread overview]
Message-ID: <87efaql3hy.fsf@gmail.com> (raw)
In-Reply-To: <cu7tvjo3zwo.fsf@systemreboot.net> (Arun Isaac's message of "Sat, 08 Dec 2018 19:04:47 +0530")

Hi,

Arun Isaac <arunisaac@systemreboot.net> writes:

>> If they are sorted, I have to add comment for each test input:
>>
>>   `(("aspell-dict-en", aspecll-dict-en) ; for test
>>     ("glib" ,glib "bin")
>>     ("pkg-config" ,pkg-config)
>>     ("xmllint" ,libxml2)
>>     ("xorg-server" ,xorg-server))       ; for test
>>
>> Which will be a little annoying...
>
> I too find this convincing. It's not a good idea to enforce sorted
> inputs all the time. If there is sufficient consensus, we can close this
> bug report.

Maybe our test inputs should have their own field? This would make their
raison d'être explicit and remove the need of using comments.

Maxim

  reply	other threads:[~2018-12-09 22:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-02  7:42 [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted Arun Isaac
2018-12-03 13:31 ` Ludovic Courtès
2018-12-04  9:13   ` Tobias Geerinckx-Rice
2018-12-08 13:29     ` Ludovic Courtès
2018-12-06  0:42   ` Oleg Pykhalov
2018-12-06 12:31     ` swedebugia
2018-12-07 13:08       ` Maxim Cournoyer
2018-12-08  3:51 ` 宋文武
2018-12-08  7:58   ` swedebugia
2018-12-08 13:34   ` Arun Isaac
2018-12-09 22:49     ` Maxim Cournoyer [this message]
2018-12-10 11:45       ` 宋文武
2018-12-10 11:19     ` 宋文武
2018-12-18 20:36       ` bug#33575: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efaql3hy.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=33575@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=iyzsong@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.