From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gW7tm-0003op-SY for guix-patches@gnu.org; Sun, 09 Dec 2018 17:50:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gW7tj-00022G-34 for guix-patches@gnu.org; Sun, 09 Dec 2018 17:50:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gW7ti-000223-Lt for guix-patches@gnu.org; Sun, 09 Dec 2018 17:50:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gW7ti-0008Gf-CV for guix-patches@gnu.org; Sun, 09 Dec 2018 17:50:02 -0500 Subject: [bug#33575] [PATCH] guix: lint: Add checker to check if inputs are sorted. Resent-Message-ID: From: Maxim Cournoyer References: <20181202074210.31361-1-arunisaac@systemreboot.net> <87sgz8ekvk.fsf@member.fsf.org> Date: Sun, 09 Dec 2018 17:49:45 -0500 In-Reply-To: (Arun Isaac's message of "Sat, 08 Dec 2018 19:04:47 +0530") Message-ID: <87efaql3hy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 33575@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Hi, Arun Isaac writes: >> If they are sorted, I have to add comment for each test input: >> >> `(("aspell-dict-en", aspecll-dict-en) ; for test >> ("glib" ,glib "bin") >> ("pkg-config" ,pkg-config) >> ("xmllint" ,libxml2) >> ("xorg-server" ,xorg-server)) ; for test >> >> Which will be a little annoying... > > I too find this convincing. It's not a good idea to enforce sorted > inputs all the time. If there is sufficient consensus, we can close this > bug report. Maybe our test inputs should have their own field? This would make their raison d'=C3=AAtre explicit and remove the need of using comments. Maxim