* [bug#52738] [PATCH] gnu: Add poweralertd
@ 2021-12-22 17:51 Josselin Poiret via Guix-patches via
2021-12-23 11:11 ` Xinglu Chen
0 siblings, 1 reply; 4+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2021-12-22 17:51 UTC (permalink / raw)
To: 52738; +Cc: Josselin Poiret
* gnu/packages/freedesktop.scm (poweralertd): Add variable.
---
gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index dcd1870e41..896f8e2847 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2429,6 +2429,33 @@ (define-public xdg-desktop-portal-wlr
compositors.")
(license license:expat)))
+(define-public poweralertd
+ (package
+ (name "poweralertd")
+ (version "0.2.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.sr.ht/~kennylevinsen/poweralertd")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "19rw9q4pcqw56nmzjfglfikzx5wwjl4n08awwdhg0jy1k0bm3dvp"))))
+ (build-system meson-build-system)
+ (arguments
+ '(#:configure-flags '("-Dman-pages=enabled")))
+ (native-inputs
+ (list scdoc pkg-config bash-minimal))
+ (inputs
+ (list elogind))
+ (home-page "https://git.sr.ht/~kennylevinsen/poweralertd")
+ (synopsis "Power alert daemon")
+ (description "poweralertd is a daemon that watches for UPower events and
+notifies the user using any notification daemon implementing
+@code{org.freedesktop.Notifications}.")
+ (license license:gpl3)))
+
(define-public waypipe
(package
(name "waypipe")
--
2.34.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#52738] [PATCH] gnu: Add poweralertd
2021-12-22 17:51 [bug#52738] [PATCH] gnu: Add poweralertd Josselin Poiret via Guix-patches via
@ 2021-12-23 11:11 ` Xinglu Chen
2021-12-25 11:30 ` [bug#52738] [PATCH v2] " Josselin Poiret via Guix-patches via
0 siblings, 1 reply; 4+ messages in thread
From: Xinglu Chen @ 2021-12-23 11:11 UTC (permalink / raw)
To: 52738; +Cc: Josselin Poiret
[-- Attachment #1: Type: text/plain, Size: 2138 bytes --]
Hi,
Josselin Poiret schrieb am Mittwoch der 22. Dezember 2021 um 18:51 +01:
> * gnu/packages/freedesktop.scm (poweralertd): Add variable.
> ---
> gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index dcd1870e41..896f8e2847 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -2429,6 +2429,33 @@ (define-public xdg-desktop-portal-wlr
> compositors.")
> (license license:expat)))
>
> +(define-public poweralertd
> + (package
> + (name "poweralertd")
> + (version "0.2.0")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.sr.ht/~kennylevinsen/poweralertd")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "19rw9q4pcqw56nmzjfglfikzx5wwjl4n08awwdhg0jy1k0bm3dvp"))))
> + (build-system meson-build-system)
> + (arguments
> + '(#:configure-flags '("-Dman-pages=enabled")))
> + (native-inputs
> + (list scdoc pkg-config bash-minimal))
> + (inputs
> + (list elogind))
> + (home-page "https://git.sr.ht/~kennylevinsen/poweralertd")
Nitpick: <https://sr.ht/~kennylevinsen/poweralertd> seems more
appropriate since it also contains links to the ML and bug tracker.
> + (synopsis "Power alert daemon")
> + (description "poweralertd is a daemon that watches for UPower events and
> +notifies the user using any notification daemon implementing
> +@code{org.freedesktop.Notifications}.")
> + (license license:gpl3)))
The LICENSE file doesn’t mention “only v3”, so it should probably be
‘gpl3+’.
Otherwise, LGTM!
--8<---------------cut here---------------start------------->8---
Result of running `guix review 20211222175135.8490-1-dev@jpoiret.xyz -D': (still a WIP)
Successfully built 1 out of 1 package(s).
No lint warnings were emitted
--8<---------------cut here---------------end--------------->8---
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#52738] [PATCH v2] gnu: Add poweralertd
2021-12-23 11:11 ` Xinglu Chen
@ 2021-12-25 11:30 ` Josselin Poiret via Guix-patches via
2022-01-16 23:23 ` bug#52738: " Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2021-12-25 11:30 UTC (permalink / raw)
To: Xinglu Chen, 52738; +Cc: Josselin Poiret
* gnu/packages/freedesktop.scm (poweralertd): Add variable.
---
Hello,
Here is a modified patch with those changes.
Thanks for the review!
Best,
Josselin
gnu/packages/freedesktop.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
index dcd1870e41..e8e1cb9ca4 100644
--- a/gnu/packages/freedesktop.scm
+++ b/gnu/packages/freedesktop.scm
@@ -2429,6 +2429,33 @@ (define-public xdg-desktop-portal-wlr
compositors.")
(license license:expat)))
+(define-public poweralertd
+ (package
+ (name "poweralertd")
+ (version "0.2.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://git.sr.ht/~kennylevinsen/poweralertd")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "19rw9q4pcqw56nmzjfglfikzx5wwjl4n08awwdhg0jy1k0bm3dvp"))))
+ (build-system meson-build-system)
+ (arguments
+ '(#:configure-flags '("-Dman-pages=enabled")))
+ (native-inputs
+ (list scdoc pkg-config bash-minimal))
+ (inputs
+ (list elogind))
+ (home-page "https://sr.ht/~kennylevinsen/poweralertd")
+ (synopsis "Power alert daemon")
+ (description "poweralertd is a daemon that watches for UPower events and
+notifies the user using any notification daemon implementing
+@code{org.freedesktop.Notifications}.")
+ (license license:gpl3+)))
+
(define-public waypipe
(package
(name "waypipe")
--
2.34.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#52738: [PATCH v2] gnu: Add poweralertd
2021-12-25 11:30 ` [bug#52738] [PATCH v2] " Josselin Poiret via Guix-patches via
@ 2022-01-16 23:23 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2022-01-16 23:23 UTC (permalink / raw)
To: Josselin Poiret via Guix-patches via
Cc: Josselin Poiret, Xinglu Chen, 52738-done
Hello,
Josselin Poiret via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/freedesktop.scm (poweralertd): Add variable.
Applied. Thank you and thanks to Xinglu Chen for the review.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-16 23:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 17:51 [bug#52738] [PATCH] gnu: Add poweralertd Josselin Poiret via Guix-patches via
2021-12-23 11:11 ` Xinglu Chen
2021-12-25 11:30 ` [bug#52738] [PATCH v2] " Josselin Poiret via Guix-patches via
2022-01-16 23:23 ` bug#52738: " Nicolas Goaziou
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.