From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 59239@debbugs.gnu.org,
"Mădălin Ionel Patrașcu" <madalinionel.patrascu@mdc-berlin.de>
Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient.
Date: Tue, 21 Mar 2023 09:06:09 -0400 [thread overview]
Message-ID: <87edpis18e.fsf_-_@gmail.com> (raw)
In-Reply-To: <87v8ndu8ew.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 17 Nov 2022 12:24:27 +0100")
Hello Mădălin,
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi Mădălin,
>
>> * gnu/packages/python-xyz.scm (python-synapseclient): New variable.
> […]
>
>> + ;;(method url-fetch)
>> + ;;(uri (pypi-uri "synapseclient" version))
>> + ;;(sha256
>> + ;; (base32
>> + ;; "1g2n5bbq5vkvprk4ap3sbz2q39cjwl8igy3krlskg34c1q7if7r4"))))
>
> Please remove this commented code.
>
>> + (build-system python-build-system)
>> + (arguments
>> + '(#:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'relax-version-requirements
>> + (lambda _
>> + (substitute* "setup.py"
>> + (("keyring>=15,<23\\.5") "keyring>=15")
>
> Is this really a good idea? Upper bounds usually exist for a reason.
> We currently have version 23.9. Can you please clear this with upstream
> first?
>
>> + (("keyrings\\.alt==3\\.1") "keyrings.alt>=3.1"))))
>> + (add-before 'build 'set-homeless-shelter
>> + (lambda _
>> + ;; could not create '/homeless-shelter': Permission denied
>> + (setenv "HOME" "/tmp")))
>
> We’re setting HOME, not homeless-shelter.
>
>> + (replace 'check
>> + (lambda* (#:key tests? #:allow-other-keys)
>> + (when tests?
>> + ;; these tests require server authentification SynapseNoCredentialsError
>> + (delete-file-recursively "tests/integration/synapseclient")
>> + (delete-file-recursively "tests/integration/synapseutils")
>> + (invoke "pytest")))))))
>
> typo: “authentication”. What exactly does this error mean? Does it
> talk to the internet? How are these tests supposed to be run?
>
> Is it possible to disable these tests with an option to pytest? That
> would seem better than conditionally deleting them.
>
> Finally, I think the test files should be deleted unconditionally, so
> that “tests?” only governs whether the tests are *run* instead of also
> causing other side effects.
Genle ping. Could you please send a v2 with the above suggested
changes?
--
Thanks,
Maxim
prev parent reply other threads:[~2023-03-21 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 5:43 [bug#59239] [PATCH] gnu: Add python-synapseclient Mădălin Ionel Patrașcu
2022-11-17 10:14 ` Jonathan Brielmaier
2022-11-17 11:24 ` Ricardo Wurmus
2023-03-21 13:06 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edpis18e.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=59239@debbugs.gnu.org \
--cc=madalinionel.patrascu@mdc-berlin.de \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.