From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mMHlHwKsGWSISAAASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 14:07:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +O3hHgKsGWSAPgEAG6o9tA (envelope-from ) for ; Tue, 21 Mar 2023 14:07:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33FDFD83E for ; Tue, 21 Mar 2023 14:07:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pebhf-0004Vl-K8; Tue, 21 Mar 2023 09:07:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pebhe-0004Ur-A1 for guix-patches@gnu.org; Tue, 21 Mar 2023 09:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pebhd-0006Kc-U8 for guix-patches@gnu.org; Tue, 21 Mar 2023 09:07:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pebhd-0006Jd-PB for guix-patches@gnu.org; Tue, 21 Mar 2023 09:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59239 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ricardo Wurmus Cc: 59239@debbugs.gnu.org, =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= Received: via spool by 59239-submit@debbugs.gnu.org id=B59239.167940397824195 (code B ref 59239); Tue, 21 Mar 2023 13:07:01 +0000 Received: (at 59239) by debbugs.gnu.org; 21 Mar 2023 13:06:18 +0000 Received: from localhost ([127.0.0.1]:57877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pebgw-0006IB-3j for submit@debbugs.gnu.org; Tue, 21 Mar 2023 09:06:18 -0400 Received: from mail-qt1-f176.google.com ([209.85.160.176]:45939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pebgu-0006Hy-Je for 59239@debbugs.gnu.org; Tue, 21 Mar 2023 09:06:16 -0400 Received: by mail-qt1-f176.google.com with SMTP id t19so3577533qta.12 for <59239@debbugs.gnu.org>; Tue, 21 Mar 2023 06:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679403971; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=kzrtCevSCIXeippk59wY2rFQLaUp5mZ2veQy9aLuX78=; b=VS0yNidoDNfPKCYMjD1FCU8cTC4UdpA90R2a1b5I/pFkhRb6CXWH9eMqXZVILzh3++ nbqTtcYvbuz1eGM05hdpWYUjngDcW0jpQStIuxejNUEHvFDmXmbykYAH8nV6T2PbYcwJ WsjrXAwl0M4y1kVSzHG+R8ZYn1o6EeCKiJl09YhAFFnx3ippSiVFzEd33CtHOGPhypXz h+IZCZvRROc/w4UMvjMzpTf8Swvqi7S4WhiY0G5qlkKrmX6rlOlCUCYAZMIyv7yEKZIU GtguQTfUv45LaN2Lbk/5ewrloeHm/pGl+dLaN3GtG48TxOuozF1oTMje2K494UnOsf7z 9jfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679403971; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kzrtCevSCIXeippk59wY2rFQLaUp5mZ2veQy9aLuX78=; b=fY5g6nmOwrJB9lB7tFGUrXOWBdvSpe5MfXHI01rMnS35gcjlcdfgjHnf9mztefRI7d kFDl59O4Q/L2rviSuVrUaO9iO3P6qz1+e/2aHs/npzQwJcXQE7SEFB0yhlGzJaF4DDAy lSxzk8Tk7pgKIXoeYom5QTwzqIfcQW6iMLm0d5ryicraWN1Gz8lSlr27v/EWBjmrHslr QMrj+3ik0RWJlBj4mUUqKyII6hCuktxa1ysKLk2iEMYVWHTpflts+bbdKEXvLJhzdr0X CisUkLP8wDS284FwbUFcYWQuJuLZuRxWxQFVcBOg8ZS0B7RMVGsFQ7W03n8Wa9zuue0w n+nQ== X-Gm-Message-State: AO0yUKU0wHjQxew1RNO8sFnygC9g4gdgTD6ZHrc0LJyJrwGKjX5c51v2 qhpa8lV0lXrbuy6yEP9wCETGZCeApMB+yw== X-Google-Smtp-Source: AK7set8gyagrgOSf+RsMIW6oJBpwMCSDOH803v1cJ2OoAunIfO2KsRCobPCT+Gs+5aOz5Ru+g/yyXQ== X-Received: by 2002:a05:622a:1a86:b0:3b3:7d5:a752 with SMTP id s6-20020a05622a1a8600b003b307d5a752mr3813417qtc.50.1679403970971; Tue, 21 Mar 2023 06:06:10 -0700 (PDT) Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195]) by smtp.gmail.com with ESMTPSA id i18-20020ac84f52000000b003d621964626sm8363391qtw.8.2023.03.21.06.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 06:06:10 -0700 (PDT) From: Maxim Cournoyer References: <20221113054308.5582-1-madalinionel.patrascu@mdc-berlin.de> <87v8ndu8ew.fsf@elephly.net> Date: Tue, 21 Mar 2023 09:06:09 -0400 In-Reply-To: <87v8ndu8ew.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 17 Nov 2022 12:24:27 +0100") Message-ID: <87edpis18e.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679404034; a=rsa-sha256; cv=none; b=L0J5Pd9pJoFkz9d8f16DiQ0+kdNI6OdleWcl2Aaa69OywQFINtCj9KWioE+GNNMikPsDSf U9mEQXle8igvCnjcZZ6F/TXTPlogTcmvGUwB8zhvG4ILsPLlTHJAAbJxTE5zypyExbEsQe gFQzN9PDmPQFo8hlXoUU2ZupEWUfXLzlyUDCPxpH/tQZ9E7BUCyZ98xe2pfooufl5Urcf/ fhEDVzzS2QSgoMg1cugud1fwoWSu1xnyV7lMzpxNmHMadvYzDkp3LHBH1G51SD8Jp+J/TU BJlofkUiNrvWsVa24SW/ss7+DxNR5Sr3+y533EaR5klFXI3XhXIItVUY6ng9qw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VS0yNido; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679404034; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kzrtCevSCIXeippk59wY2rFQLaUp5mZ2veQy9aLuX78=; b=eeidIdGvEfVdlOwapiDWjYCAjSSJCATrXuG9HcvhmSE1O9fEmmLyEx7fJQtAp1tjH8V/OU HcRum0+sMzG6JsiZKBWLQvbrOr8UzKMUXRvG/YfhLcS+x3hV01k1IDb2zlDwGb6Wi/A0sP MJauVEAdUuIXMd2RGmrVGNQ8kp6WsMhgAlYL9VmgLaooc2tVJ8mA5kWRmTJNpqIHXhMDww +3sXYyjdTqmGDSReC57XtFFeEamSA5XyJlHITkhrm5wI7kYsaopEaFBApsaFX8a+gy7rS+ vsh0OQq37RyFZVT+h8wOTAkA4GAV0+RgS/x/O/wzZztSo9Pd3j4SqObK2un35A== X-Migadu-Spam-Score: 5.75 X-Spam-Score: 5.75 X-Migadu-Queue-Id: 33FDFD83E Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=VS0yNido; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: 7CA9L5LY3EUE Hello M=C4=83d=C4=83lin, Ricardo Wurmus writes: > Hi M=C4=83d=C4=83lin, > >> * gnu/packages/python-xyz.scm (python-synapseclient): New variable. > [=E2=80=A6] > >> + ;;(method url-fetch) >> + ;;(uri (pypi-uri "synapseclient" version)) >> + ;;(sha256 >> + ;; (base32 >> + ;; "1g2n5bbq5vkvprk4ap3sbz2q39cjwl8igy3krlskg34c1q7if7r4= ")))) > > Please remove this commented code. > >> + (build-system python-build-system) >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'relax-version-requirements >> + (lambda _ >> + (substitute* "setup.py" >> + (("keyring>=3D15,<23\\.5") "keyring>=3D15") > > Is this really a good idea? Upper bounds usually exist for a reason. > We currently have version 23.9. Can you please clear this with upstream > first? > >> + (("keyrings\\.alt=3D=3D3\\.1") "keyrings.alt>=3D3.1")))) >> + (add-before 'build 'set-homeless-shelter >> + (lambda _ >> + ;; could not create '/homeless-shelter': Permission denied >> + (setenv "HOME" "/tmp"))) > > We=E2=80=99re setting HOME, not homeless-shelter. > >> + (replace 'check >> + (lambda* (#:key tests? #:allow-other-keys) >> + (when tests? >> + ;; these tests require server authentification SynapseN= oCredentialsError >> + (delete-file-recursively "tests/integration/synapseclien= t") >> + (delete-file-recursively "tests/integration/synapseutils= ") >> + (invoke "pytest"))))))) > > typo: =E2=80=9Cauthentication=E2=80=9D. What exactly does this error mea= n? Does it > talk to the internet? How are these tests supposed to be run? > > Is it possible to disable these tests with an option to pytest? That > would seem better than conditionally deleting them. > > Finally, I think the test files should be deleted unconditionally, so > that =E2=80=9Ctests?=E2=80=9D only governs whether the tests are *run* in= stead of also > causing other side effects. Genle ping. Could you please send a v2 with the above suggested changes? --=20 Thanks, Maxim