GitHub updater broken?

GitHub updater broken?

[Ludovic Courtès]

Hi Ben,

The GitHub updater always returns 403 (“Forbidden”) now.  I tried
passing a token and that didn’t help, but maybe I did not check the
right boxes at <https://github.com/settings/tokens/new>.

Any idea what can be done about it?

Thanks,
Ludo’.

Re: GitHub updater broken?

[Ben Woodcroft]

Hi Ludo,


On 11/01/17 00:37, Ludovic Courtès wrote:
> Hi Ben,
>
> The GitHub updater always returns 403 (“Forbidden”) now.  I tried
> passing a token and that didn’t help, but maybe I did not check the
> right boxes at <https://github.com/settings/tokens/new>.
>
> Any idea what can be done about it?

It seems GitHub requires a User-Agent to be set, the response-body not 
reported by http-fetch says as much in agreement with the documention:
https://developer.github.com/v3/#user-agent-required

I'm afraid I'm afk for the next week and a bit, I can try to send a 
patch after that, or perhaps someone else can implement this probably 
small change.

Thanks, ben.

Re: GitHub updater broken?

[Ludovic Courtès]

Hello,

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 11/01/17 00:37, Ludovic Courtès wrote:
>> Hi Ben,
>>
>> The GitHub updater always returns 403 (“Forbidden”) now.  I tried
>> passing a token and that didn’t help, but maybe I did not check the
>> right boxes at <https://github.com/settings/tokens/new>.
>>
>> Any idea what can be done about it?
>
> It seems GitHub requires a User-Agent to be set, the response-body not
> reported by http-fetch says as much in agreement with the documention:
> https://developer.github.com/v3/#user-agent-required
>
> I'm afraid I'm afk for the next week and a bit, I can try to send a
> patch after that, or perhaps someone else can implement this probably
> small change.

Indeed.  There was additionally a regression I had introduced a couple
of weeks ago.  Both are fixed:

608a50b66 * http-client: Provide 'User-Agent' header by default.
4cd5ec801 * import: github: Fix regression on the /releases retrieval.

Thank you!

Ludo’.