all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: julien@lepiller.eu
Cc: 28841@debbugs.gnu.org
Subject: [bug#28841] [PATCH 02/24] gnu: Add java-tomcat.
Date: Wed, 18 Oct 2017 22:42:23 +0200	[thread overview]
Message-ID: <87d15k428g.fsf@elephly.net> (raw)
In-Reply-To: <20171014222349.12902-2-julien@lepiller.eu>


Hi again,

> * gnu/packages/java.scm (java-tomcat): New variable.
> ---

[…]

> +    (inputs
> +     `(("java-eclipse-jdt-core" ,java-eclipse-jdt-core)))

Actually … I’m *very* surprised that this is the only input here.  I
remember trying to package this early on, but failing because there were
so many unpackaged dependencies.

Are you sure this is the only required input here?  Do the sources come
with bundled jars?

> +         (add-after 'unpack 'properties
> +           (lambda _
> +             (mkdir "downloads")
> +             (substitute* "build.xml"
> +               (("download-compile,") "")
> +               (("depends=\"validate\"") "depends=\"build-prepare\"")
> +               ((",download-validate") ""))
> +             (with-output-to-file "build.properties"
> +               (lambda _
> +                 (display
> +                   (string-append "base.path=" (getcwd)
> "/downloads\n"))))))

Forgot to say this in my previous comment: please end this phase with “#t”.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  parent reply	other threads:[~2017-10-18 20:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-14 21:32 [bug#28841] [PATCH] New java packages Julien Lepiller
2017-10-14 22:23 ` [bug#28841] [PATCH 01/24] gnu: Add java-hdrhistogram julien
2017-10-14 22:23   ` [bug#28841] [PATCH 02/24] gnu: Add java-tomcat julien
2017-10-18 20:36     ` Ricardo Wurmus
2017-10-18 20:42     ` Ricardo Wurmus [this message]
2017-10-19  9:45       ` julien lepiller
2017-10-18 20:51     ` Ricardo Wurmus
2017-10-14 22:23   ` [bug#28841] [PATCH 03/24] gnu: Add java-eclipse-jetty-test-helper julien
2017-10-18 20:50     ` Ricardo Wurmus
2017-10-19  9:57       ` julien lepiller
2017-10-22 12:11         ` Julien Lepiller
2017-10-22 14:46           ` Ricardo Wurmus
2017-10-23  7:15             ` julien lepiller
2017-10-14 22:23   ` [bug#28841] [PATCH 04/24] gnu: Add java-eclipse-jetty-perf-helper julien
2017-10-14 22:23   ` [bug#28841] [PATCH 05/24] gnu: Add java-eclipse-jetty-util julien
2017-10-14 22:23   ` [bug#28841] [PATCH 06/24] gnu: Add java-eclipse-jetty-util-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 07/24] gnu: Add java-eclipse-jetty-io julien
2017-10-14 22:23   ` [bug#28841] [PATCH 08/24] gnu: Add java-eclipse-jetty-io-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 09/24] gnu: Add java-eclipse-jetty-http julien
2017-10-14 22:23   ` [bug#28841] [PATCH 10/24] gnu: Add java-eclipse-jetty-http-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 11/24] gnu: Add java-eclipse-jetty-jmx julien
2017-10-14 22:23   ` [bug#28841] [PATCH 12/24] gnu: Add java-eclipse-jetty-jmx-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 13/24] gnu: Add java-eclipse-jetty-server julien
2017-10-14 22:23   ` [bug#28841] [PATCH 14/24] gnu: Add java-eclipse-jetty-server-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 15/24] gnu: Add java-eclipse-jetty-security julien
2017-10-14 22:23   ` [bug#28841] [PATCH 16/24] gnu: Add java-eclipse-jetty-security-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 17/24] gnu: Add java-eclipse-jetty-servlet julien
2017-10-14 22:23   ` [bug#28841] [PATCH 18/24] gnu: Add java-eclipse-jetty-servlet-9.2 julien
2017-10-14 22:23   ` [bug#28841] [PATCH 19/24] gnu: Add java-aopalliance julien
2017-10-14 22:23   ` [bug#28841] [PATCH 20/24] gnu: Add java-javax-inject julien
2017-10-14 22:23   ` [bug#28841] [PATCH 21/24] gnu: Add java-guice julien
2017-10-14 22:23   ` [bug#28841] [PATCH 22/24] gnu: Add java-guice-servlet julien
2017-10-14 22:23   ` [bug#28841] [PATCH 23/24] gnu: Add java-assertj julien
2017-10-14 22:23   ` [bug#28841] [PATCH 24/24] gnu: Add java-jboss-javassist julien
2017-10-18 20:40   ` [bug#28841] [PATCH 01/24] gnu: Add java-hdrhistogram Ricardo Wurmus
2017-10-23 20:58 ` bug#28841: [PATCH] New java packages Julien Lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d15k428g.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=28841@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.