From: julien lepiller <julien@lepiller.eu>
To: 28841@debbugs.gnu.org
Subject: [bug#28841] [PATCH 02/24] gnu: Add java-tomcat.
Date: Thu, 19 Oct 2017 11:45:28 +0200 [thread overview]
Message-ID: <708a71e62e147b8e0e9e93de4870d844@lepiller.eu> (raw)
In-Reply-To: <87d15k428g.fsf@elephly.net>
Le 2017-10-18 22:42, Ricardo Wurmus a écrit :
> Hi again,
>
>> * gnu/packages/java.scm (java-tomcat): New variable.
>> ---
>
> […]
>
>> + (inputs
>> + `(("java-eclipse-jdt-core" ,java-eclipse-jdt-core)))
>
> Actually … I’m *very* surprised that this is the only input here. I
> remember trying to package this early on, but failing because there
> were
> so many unpackaged dependencies.
>
> Are you sure this is the only required input here? Do the sources come
> with bundled jars?
I've added this to a phase:
(for-each delete-file (find-files "." ".*.jar$"))
and it still builds correctly, so i'm fairly confident that's the only
required dependency. The tests though have a lot of dependencies that
are fetched by the build script, but it's disabled in the "properties"
phase (I should use a different phase though, because it has nothing to
do with properties).
Now I have no idea how tomcat is supposed to work. I only need it
because it has a more recent version of the servlet api that is required
at least by jetty, and that part at least is correct. Maybe some of the
dependencies are actually run-time dependencies? At first I wanted to
create only a java-tomcat-servlet-api package, but I can't use the
upstream build.xml for that.
I will apply all your suggestions of course.
Thank you for the review!
next prev parent reply other threads:[~2017-10-19 9:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 21:32 [bug#28841] [PATCH] New java packages Julien Lepiller
2017-10-14 22:23 ` [bug#28841] [PATCH 01/24] gnu: Add java-hdrhistogram julien
2017-10-14 22:23 ` [bug#28841] [PATCH 02/24] gnu: Add java-tomcat julien
2017-10-18 20:36 ` Ricardo Wurmus
2017-10-18 20:42 ` Ricardo Wurmus
2017-10-19 9:45 ` julien lepiller [this message]
2017-10-18 20:51 ` Ricardo Wurmus
2017-10-14 22:23 ` [bug#28841] [PATCH 03/24] gnu: Add java-eclipse-jetty-test-helper julien
2017-10-18 20:50 ` Ricardo Wurmus
2017-10-19 9:57 ` julien lepiller
2017-10-22 12:11 ` Julien Lepiller
2017-10-22 14:46 ` Ricardo Wurmus
2017-10-23 7:15 ` julien lepiller
2017-10-14 22:23 ` [bug#28841] [PATCH 04/24] gnu: Add java-eclipse-jetty-perf-helper julien
2017-10-14 22:23 ` [bug#28841] [PATCH 05/24] gnu: Add java-eclipse-jetty-util julien
2017-10-14 22:23 ` [bug#28841] [PATCH 06/24] gnu: Add java-eclipse-jetty-util-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 07/24] gnu: Add java-eclipse-jetty-io julien
2017-10-14 22:23 ` [bug#28841] [PATCH 08/24] gnu: Add java-eclipse-jetty-io-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 09/24] gnu: Add java-eclipse-jetty-http julien
2017-10-14 22:23 ` [bug#28841] [PATCH 10/24] gnu: Add java-eclipse-jetty-http-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 11/24] gnu: Add java-eclipse-jetty-jmx julien
2017-10-14 22:23 ` [bug#28841] [PATCH 12/24] gnu: Add java-eclipse-jetty-jmx-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 13/24] gnu: Add java-eclipse-jetty-server julien
2017-10-14 22:23 ` [bug#28841] [PATCH 14/24] gnu: Add java-eclipse-jetty-server-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 15/24] gnu: Add java-eclipse-jetty-security julien
2017-10-14 22:23 ` [bug#28841] [PATCH 16/24] gnu: Add java-eclipse-jetty-security-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 17/24] gnu: Add java-eclipse-jetty-servlet julien
2017-10-14 22:23 ` [bug#28841] [PATCH 18/24] gnu: Add java-eclipse-jetty-servlet-9.2 julien
2017-10-14 22:23 ` [bug#28841] [PATCH 19/24] gnu: Add java-aopalliance julien
2017-10-14 22:23 ` [bug#28841] [PATCH 20/24] gnu: Add java-javax-inject julien
2017-10-14 22:23 ` [bug#28841] [PATCH 21/24] gnu: Add java-guice julien
2017-10-14 22:23 ` [bug#28841] [PATCH 22/24] gnu: Add java-guice-servlet julien
2017-10-14 22:23 ` [bug#28841] [PATCH 23/24] gnu: Add java-assertj julien
2017-10-14 22:23 ` [bug#28841] [PATCH 24/24] gnu: Add java-jboss-javassist julien
2017-10-18 20:40 ` [bug#28841] [PATCH 01/24] gnu: Add java-hdrhistogram Ricardo Wurmus
2017-10-23 20:58 ` bug#28841: [PATCH] New java packages Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=708a71e62e147b8e0e9e93de4870d844@lepiller.eu \
--to=julien@lepiller.eu \
--cc=28841@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.