[bug#33101] [PATCH] gnu: light: Update to 1.2.

[bug#33101] [PATCH] gnu: light: Update to 1.2.

[Pierre Langlois]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]


Hello guix!

Here's a patch to update the `light` utility. It looks like upstream has
moved to a full GNU build system so we don't need to adapt phases
nymore :-). Also, the dependency on help2man was dropped.

Thanks!
Pierre


[-- Attachment #2: 0001-gnu-light-Update-to-1.2.patch --]
[-- Type: text/x-patch, Size: 2530 bytes --]

From 411309b19a678f3f0076bb66f95baab7706cd605 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Sat, 20 Oct 2018 11:17:24 +0100
Subject: [PATCH] gnu: light: Update to 1.2.

* gnu/packages/linux.scm (light): Update to 1.2.
[source]: Switch to url-fetch.
[arguments]: Remove.
[native-inputs]: Remove help2man. Add autoconf and automake.
---
 gnu/packages/linux.scm | 27 +++++++++------------------
 1 file changed, 9 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 6a89caf27..94e7a6d97 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -30,6 +30,7 @@
 ;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby@inria.fr>
 ;;; Copyright © 2018 Brendan Tildesley <brendan.tildesley@openmailbox.org>
 ;;; Copyright © 2018 Manuel Graf <graf@init.at>
+;;; Copyright © 2018 Pierre Langlois <pierre.langlois@gmx.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4167,29 +4168,19 @@ monitoring tools for Linux.  These include @code{mpstat}, @code{iostat},
 (define-public light
   (package
     (name "light")
-    (version "1.1.2")
+    (version "1.2")
     (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/haikarainen/light")
-                    (commit version)))
+              (method url-fetch)
+              (uri (string-append
+                     "https://github.com/haikarainen/light/archive/v"
+                     version ".tar.gz"))
               (sha256
                (base32
-                "0c934gxav9cgdf94li6dp0rfqmpday9d33vdn9xb2mfp4war9n4w"))))
+                "1gfvsw7gh5pis733l7j54vzp272pvjyzbg8a0pvapfmg0s7mip97"))))
     (build-system gnu-build-system)
-    (arguments
-     '(#:tests? #f                      ; no tests
-       #:make-flags (list "CC=gcc"
-                          (string-append "PREFIX=" %output))
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure)            ; no configure script
-         (add-after 'unpack 'patch-makefile
-           (lambda _
-             (substitute* "Makefile" (("chown") "#"))
-             #t)))))
     (native-inputs
-     `(("help2man" ,help2man)))
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
     (home-page "https://haikarainen.github.io/light")
     (synopsis "GNU/Linux application to control backlights")
     (description
-- 
2.19.1

bug#33101: [PATCH] gnu: light: Update to 1.2.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Pierre,

Pierre Langlois <pierre.langlois@gmx.com> skribis:

>>From 411309b19a678f3f0076bb66f95baab7706cd605 Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois@gmx.com>
> Date: Sat, 20 Oct 2018 11:17:24 +0100
> Subject: [PATCH] gnu: light: Update to 1.2.
>
> * gnu/packages/linux.scm (light): Update to 1.2.
> [source]: Switch to url-fetch.
> [arguments]: Remove.
> [native-inputs]: Remove help2man. Add autoconf and automake.

Awesome, applied.  I also make the changes below to please ‘guix lint’.

Thank you!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 948 bytes --]

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 94e7a6d97..4d4c36412 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4176,12 +4176,13 @@ monitoring tools for Linux.  These include @code{mpstat}, @code{iostat},
                      version ".tar.gz"))
               (sha256
                (base32
-                "1gfvsw7gh5pis733l7j54vzp272pvjyzbg8a0pvapfmg0s7mip97"))))
+                "1gfvsw7gh5pis733l7j54vzp272pvjyzbg8a0pvapfmg0s7mip97"))
+              (file-name (string-append name "-" version ".tar.gz"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("autoconf" ,autoconf)
        ("automake" ,automake)))
-    (home-page "https://haikarainen.github.io/light")
+    (home-page "https://haikarainen.github.io/light/")
     (synopsis "GNU/Linux application to control backlights")
     (description
      "Light is a program to send commands to screen backlight controllers