* bug#33721: ci.guix.info does not return Cache-Control header for substitutes
@ 2018-12-13 6:58 Chris Marusich
2018-12-17 22:38 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Chris Marusich @ 2018-12-13 6:58 UTC (permalink / raw)
To: 33721
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
Hi,
I've noticed that ci.guix.info (which I see maps to the same IP address
as berlin.guixsd.org) does not return a Cache-Control header for some
substitutes. I've tried various URLs under the /nar/gzip/ prefix, and
and they all omitted a Cache-Control header in the response. For
example:
--8<---------------cut here---------------start------------->8---
$ curl --dump-header - -s -o /dev/null https://ci.guix.info/nar/gzip/0fw7w396llw316nj36dsqnbkxzc9bqwa-python-itsdangerous-0.24
HTTP/1.1 200 OK
Server: nginx/1.14.1
Date: Thu, 13 Dec 2018 06:49:04 GMT
Content-Type: application/octet-stream;charset=ISO-8859-1
Content-Length: 19449
Connection: keep-alive
--8<---------------cut here---------------end--------------->8---
However, some URLs do include a Cache-Control header in the response.
For example:
--8<---------------cut here---------------start------------->8---
$ curl --dump-header - -s -o /dev/null https://ci.guix.info/s8v7vrzgpjkyf72dlbifhprabqqlx696.narinfo
HTTP/1.1 200 OK
Server: nginx/1.14.1
Date: Thu, 13 Dec 2018 06:49:25 GMT
Content-Type: application/x-nix-narinfo;charset=utf-8
Content-Length: 1456
Connection: keep-alive
Cache-Control: max-age=7776000
--8<---------------cut here---------------end--------------->8---
I expected all URLs to return an appropriate Cache-Control header (at
least when returning an HTTP 200 response), especially the URLs for the
gzipped substitutes themselves, since they are likely to be large. Is
there a reason why we do not include a Cache-Control header for all
substitutes under the /nar/gzip/ prefix?
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#33721: ci.guix.info does not return Cache-Control header for substitutes
2018-12-13 6:58 bug#33721: ci.guix.info does not return Cache-Control header for substitutes Chris Marusich
@ 2018-12-17 22:38 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2018-12-17 22:38 UTC (permalink / raw)
To: Chris Marusich; +Cc: 33721
Hi Chris,
Chris Marusich <cmmarusich@gmail.com> skribis:
> I've noticed that ci.guix.info (which I see maps to the same IP address
> as berlin.guixsd.org) does not return a Cache-Control header for some
> substitutes. I've tried various URLs under the /nar/gzip/ prefix, and
> and they all omitted a Cache-Control header in the response. For
> example:
Until now ‘guix publish’ would set ‘Cache-Control’ headers only on
narinfo responses. The idea was that nars themselves can be cached
forever. However it probably makes more sense to set the same
‘Cache-Control’ header on nar responses.
Fixed in 9b9de08477afe0ea519f916ad3d33c9720c3278d.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-17 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-13 6:58 bug#33721: ci.guix.info does not return Cache-Control header for substitutes Chris Marusich
2018-12-17 22:38 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.