all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.
@ 2020-04-26 18:58 Christopher Baines
  2020-04-26 19:14 ` Christopher Baines
  2020-04-28 14:39 ` Marius Bakke
  0 siblings, 2 replies; 4+ messages in thread
From: Christopher Baines @ 2020-04-26 18:58 UTC (permalink / raw)
  To: 40876

* gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
---
 gnu/packages/bdw-gc.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
index 112a161f94..50e4951dc1 100644
--- a/gnu/packages/bdw-gc.scm
+++ b/gnu/packages/bdw-gc.scm
@@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
    libgc
    (arguments (substitute-keyword-arguments (package-arguments libgc)
                 ((#:configure-flags flags ''())
-                 `(cons "--enable-static" ,flags))))))
+                 `(cons "--enable-static" ,flags))))
+   (properties '((hidden? . #t)))))
 
 (define-public libgc-7
   (package
-- 
2.26.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.
  2020-04-26 18:58 [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden Christopher Baines
@ 2020-04-26 19:14 ` Christopher Baines
  2020-04-28 14:39 ` Marius Bakke
  1 sibling, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2020-04-26 19:14 UTC (permalink / raw)
  To: 40876, mbakke

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]


Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
> ---
>  gnu/packages/bdw-gc.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
> index 112a161f94..50e4951dc1 100644
> --- a/gnu/packages/bdw-gc.scm
> +++ b/gnu/packages/bdw-gc.scm
> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>     libgc
>     (arguments (substitute-keyword-arguments (package-arguments libgc)
>                  ((#:configure-flags flags ''())
> -                 `(cons "--enable-static" ,flags))))))
> +                 `(cons "--enable-static" ,flags))))
> +   (properties '((hidden? . #t)))))
>
>  (define-public libgc-7
>    (package

Forgot to include you Marius when I sent this patch. Does this seem
sensible?

Otherwise you get this libgc variant when you use Guix on the command
line, and commands like guix lint complain.

./pre-inst-env guix lint libgc
guix lint: warning: ambiguous package specification `libgc'
guix lint: warning: choosing libgc@8.0.4 from gnu/packages/bdw-gc.scm:90:2


I hope that setting the properties doesn't involve rebuilding anything.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.
  2020-04-26 18:58 [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden Christopher Baines
  2020-04-26 19:14 ` Christopher Baines
@ 2020-04-28 14:39 ` Marius Bakke
  2020-04-28 21:56   ` bug#40876: " Christopher Baines
  1 sibling, 1 reply; 4+ messages in thread
From: Marius Bakke @ 2020-04-28 14:39 UTC (permalink / raw)
  To: Christopher Baines, 40876

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
> ---
>  gnu/packages/bdw-gc.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
> index 112a161f94..50e4951dc1 100644
> --- a/gnu/packages/bdw-gc.scm
> +++ b/gnu/packages/bdw-gc.scm
> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>     libgc
>     (arguments (substitute-keyword-arguments (package-arguments libgc)
>                  ((#:configure-flags flags ''())
> -                 `(cons "--enable-static" ,flags))))))
> +                 `(cons "--enable-static" ,flags))))
> +   (properties '((hidden? . #t)))))

LGTM, thanks!  Properties are only used by the Guix 'front-end' and not
part of the derivation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#40876: [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden.
  2020-04-28 14:39 ` Marius Bakke
@ 2020-04-28 21:56   ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2020-04-28 21:56 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 40876-done

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]


Marius Bakke <mbakke@fastmail.com> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/bdw-gc.scm (libgc/static-libs)[properties] Set hidden? to #t.
>> ---
>>  gnu/packages/bdw-gc.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm
>> index 112a161f94..50e4951dc1 100644
>> --- a/gnu/packages/bdw-gc.scm
>> +++ b/gnu/packages/bdw-gc.scm
>> @@ -91,7 +91,8 @@ C or C++ programs, though that is not its primary goal.")
>>     libgc
>>     (arguments (substitute-keyword-arguments (package-arguments libgc)
>>                  ((#:configure-flags flags ''())
>> -                 `(cons "--enable-static" ,flags))))))
>> +                 `(cons "--enable-static" ,flags))))
>> +   (properties '((hidden? . #t)))))
>
> LGTM, thanks!  Properties are only used by the Guix 'front-end' and not
> part of the derivation.

Great, I've pushed this as 709ca6c9824e4bbb0d81959b885248294fb062ae now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-28 21:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 18:58 [bug#40876] [PATCH core-updates] gnu: libgc/static-libs: Mark it as hidden Christopher Baines
2020-04-26 19:14 ` Christopher Baines
2020-04-28 14:39 ` Marius Bakke
2020-04-28 21:56   ` bug#40876: " Christopher Baines

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.