From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 61853@debbugs.gnu.org
Subject: bug#61853: ‘guix pack’ shell tests fail
Date: Fri, 03 Mar 2023 11:43:55 +0100 [thread overview]
Message-ID: <87cz5qyv10.fsf@gnu.org> (raw)
In-Reply-To: <87v8jmilhl.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 27 Feb 2023 21:15:18 -0500")
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
[...]
>> That’s an acceptable change IMO, introduced in
>> 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were
>> evidently not run after that change, which is problematic.
>
> Interesting. I had done all my testing using tests/pack.scm (and the
> new tests/rpm.scm), and overlooked tests/pack.sh.
…
>> Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests
>> now pass for me.
>
> Thanks (again)!
To be clear, it’s time-consuming and stressful. That’s not sane and I’d
rather not work that way.
>> One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that
>> it introduces a copy of the profile being built to the store
>> (“profile-directory”). This was purposefully avoided before because
>> it’s very I/O-intensive, space-consuming, and puts more pressure on the
>> store. It’s a pattern we avoided for system images too, having noticed
>> its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.)
>>
>> We may need to come back to a single derivation well or creating packs
>> for big profiles will be too costly.
>
> I agree it's expensive; we're trading IO for storage though, so the case
> of generating the same pack in multiple format, it could be beneficial
> by only computing the union directory once. The real motivation was
> avoiding code duplication though; perhaps this could be accomplished by
> moving the common logic to (guix build pack-utils)?
Yes, that’s a good idea. There’s already (guix build pack) and I guess
we could move roughly the contents of ‘self-contained-tarball/builder’
and ‘populate-profile-root’ there.
How does that sound?
Thanks,
Ludo’.
next prev parent reply other threads:[~2023-03-03 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 21:46 bug#61853: ‘guix pack’ shell tests fail Ludovic Courtès
2023-02-27 23:07 ` Ludovic Courtès
2023-02-28 2:15 ` Maxim Cournoyer
2023-03-03 10:43 ` Ludovic Courtès [this message]
2023-03-04 3:22 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz5qyv10.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=61853@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.