From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uKv9ArnPAWQtbAEAbAwnHQ (envelope-from ) for ; Fri, 03 Mar 2023 11:45:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MKp9ArnPAWRBEQAAauVa8A (envelope-from ) for ; Fri, 03 Mar 2023 11:45:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B999131A9 for ; Fri, 3 Mar 2023 11:45:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pY2uP-0000B6-1m; Fri, 03 Mar 2023 05:45:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY2uN-0000AY-MK for bug-guix@gnu.org; Fri, 03 Mar 2023 05:45:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pY2uN-0000ae-Co for bug-guix@gnu.org; Fri, 03 Mar 2023 05:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pY2uN-0007GP-5e for bug-guix@gnu.org; Fri, 03 Mar 2023 05:45:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#61853: =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?pack=E2=80=99?= shell tests fail Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Mar 2023 10:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61853 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 61853@debbugs.gnu.org Received: via spool by 61853-submit@debbugs.gnu.org id=B61853.167784024827781 (code B ref 61853); Fri, 03 Mar 2023 10:45:03 +0000 Received: (at 61853) by debbugs.gnu.org; 3 Mar 2023 10:44:08 +0000 Received: from localhost ([127.0.0.1]:59691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY2tT-0007E1-RV for submit@debbugs.gnu.org; Fri, 03 Mar 2023 05:44:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY2tR-0007DR-NU for 61853@debbugs.gnu.org; Fri, 03 Mar 2023 05:44:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY2tM-0000CM-Bt; Fri, 03 Mar 2023 05:44:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Jo1Ia9TDhEf4oQCIq1tFmGcq//6ji0FK4qbmzDBTvus=; b=QuGAdCVnjfzOg2i2e7zf KxwZeSORFWgsI6y5gms2IFlApuPipPQGITXzxiz6dNoIliN+7h9qVuROPOJixLXdzduOwyQPDqBJN OApfNviCBRt3nOA30BNwR3faA5TYbK6Z3S8LlSJcYop4aTYrMEsU6n67tgAJ6Y4Bnk1l8/U22vCKS kkwghalUFO7PgHVHtDpOTGy/73T6D8HW5UpLpTtv2OuUYgmtE5rwoegdQWdO8h6i/r1C8yOrhFQ40 O6WEaDMFI2j/Z3X5uMNS63CgwYcsDVsbt2rAnLK+IOdhrSHTwHTNinPn15lzp98/aBSvU4RkmLvyS 59ytaXYVCjqAnA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY2tL-0005NA-Oc; Fri, 03 Mar 2023 05:43:59 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871qmahjcy.fsf@inria.fr> <87wn42emh8.fsf@gnu.org> <87v8jmilhl.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 =?UTF-8?Q?Vent=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Fumeterre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 Mar 2023 11:43:55 +0100 In-Reply-To: <87v8jmilhl.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 27 Feb 2023 21:15:18 -0500") Message-ID: <87cz5qyv10.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677840312; a=rsa-sha256; cv=none; b=seTKZAug6PSa3EInXuM4JkNfHrwh6RS/z9mhdICjVrUv+N2FLqYwJQY3tcV9FxBHRb1JL9 mUE3Jil7D03RiDioAY6MouCUx8/NOy0+ufSRwrYdN+xRFqvTZxf0oEYb42PSG/XeCNL3s7 sdEsI/+fgpJVNnvEGfazJN7uq/OHwdUHTLuZzLP2Gx57UkCsJIFhtTofRe2WNlczNKq1Tk zgFWCjoJW5TPpkqcuItCuC1X5xQttgP96BaJX51YQoj+VGqLgaXNIoAHbiTfxBYALfvym/ hS2rStxBlvzffqxlbAdDpvGrUxFVEAxkk7GysvZb5NlkRzorNgsoq6CWIYvnBw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QuGAdCVn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677840312; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Jo1Ia9TDhEf4oQCIq1tFmGcq//6ji0FK4qbmzDBTvus=; b=d5aasRV4KCHmUAu7bTb51pgI+YlylSG5c6S0EdJrtRR8SQVJHwWWBQnvshSvAfhl107WZv 07Ys+snbf81HH1Bd1WbG56ZalA0TMXz4LPwbSuD1dvwf1yygEW2xpnqC8lrvM5xfMwZ1VZ CI1r+z7AYD7UXmC0kNRcnGsRYWYz9Pdg8RCMz5JrCt+ohkWckGYEE4yd69bl8lStNUxEmR NA3Cz9f/xgmPnOvKzp3llJas34aTL17rMb8ds52kws9FLkkHsXyVHrN8UtIVCNFejTLCH/ vT2QBKydYHVx3amxG7fWSpbhfDdgxokT852LqHLMjZA7wMEyhbReHfVQryhJoA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.60 X-Spam-Score: -2.60 X-Migadu-Queue-Id: 7B999131A9 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=QuGAdCVn; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: V4GgFdk3xl8O Hi Maxim, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >> That=E2=80=99s an acceptable change IMO, introduced in >> 68380db4c40a2ee1156349a87254fd7b1f1a52d5. However, the tests were >> evidently not run after that change, which is problematic. > > Interesting. I had done all my testing using tests/pack.scm (and the > new tests/rpm.scm), and overlooked tests/pack.sh. =E2=80=A6 >> Anyway, fixed in 92a0e60a963a54230e400c5c2ae585205489bf35. Both tests >> now pass for me. > > Thanks (again)! To be clear, it=E2=80=99s time-consuming and stressful. That=E2=80=99s not= sane and I=E2=80=99d rather not work that way. >> One issue with 68380db4c40a2ee1156349a87254fd7b1f1a52d5, though, is that >> it introduces a copy of the profile being built to the store >> (=E2=80=9Cprofile-directory=E2=80=9D). This was purposefully avoided be= fore because >> it=E2=80=99s very I/O-intensive, space-consuming, and puts more pressure= on the >> store. It=E2=80=99s a pattern we avoided for system images too, having = noticed >> its cost (commit 7f75a7ec08975eb6d6e01db61bd6b91f447f655e for instance.) >> >> We may need to come back to a single derivation well or creating packs >> for big profiles will be too costly. > > I agree it's expensive; we're trading IO for storage though, so the case > of generating the same pack in multiple format, it could be beneficial > by only computing the union directory once. The real motivation was > avoiding code duplication though; perhaps this could be accomplished by > moving the common logic to (guix build pack-utils)? Yes, that=E2=80=99s a good idea. There=E2=80=99s already (guix build pack)= and I guess we could move roughly the contents of =E2=80=98self-contained-tarball/build= er=E2=80=99 and =E2=80=98populate-profile-root=E2=80=99 there. How does that sound? Thanks, Ludo=E2=80=99.