From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 31342@debbugs.gnu.org
Subject: [bug#31342] [PATCH 2/2] gnu: services: Add Enlightenment desktop service.
Date: Tue, 08 May 2018 15:24:59 +0200 [thread overview]
Message-ID: <87bmdq46vo.fsf@gnu.org> (raw)
In-Reply-To: <20180507190327.GA2707@macbook41> (Efraim Flashner's message of "Mon, 7 May 2018 22:03:27 +0300")
Hello!
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Mon, May 07, 2018 at 06:49:43PM +0200, Ludovic Courtès wrote:
[...]
>> Perhaps enlightenment_ckpasswd needs a PAM entry as well, like
>> ‘screen-locker-service-type’ does?
>>
>
> I'm not sure, enlightenment's screen locker code was refactored in
> 0.22.2 so that it would behave identically on Linux and BSD, and I'm not
> sure that the BSDs use PAM, and it seems to with as-is.
If you confirm it works as-is, that’s fine!
>> > +(define* (enlightenment-desktop-service
>> > + #:key (config (enlightenment-desktop-configuration)))
>> > + "Return a service that adds the @code{enlightenment} package to the system
>> > +profile, and extends dbus with the ability for @code{efl} to generate
>> > +thumbnails and makes setuid the programs which enlightenment expects to have
>> > +their setuid bit set."
>> > + (service enlightenment-desktop-service-type config))
>>
>> Not needed! :-)
>>
>> Thank you,
>> Ludo’.
>
> I looked at the xfce service especially, and it actually has the same
> fields and declarations as enlightenment.
Sounds good.
> I'd like to leave the option in place to add
> '(enlightenment-desktop-service)' to an OS-config since it is then
> identical to the other desktop services we have.
This style has been (informally, I admit) deprecated since we introduced
the ‘service’ form. The recommended way is to write:
(service enlightenment-service-type)
I agree it’s slightly more verbose, but it’s more “transparent.”
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-05-08 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 16:44 [bug#31342] [PATCH 0/2] Enlightenment Desktop Service Efraim Flashner
2018-05-02 16:47 ` [bug#31342] [PATCH 1/2] gnu: enlightenment: Fix setuid program locations Efraim Flashner
2018-05-02 16:47 ` [bug#31342] [PATCH 2/2] gnu: services: Add Enlightenment desktop service Efraim Flashner
2018-05-07 16:49 ` Ludovic Courtès
2018-05-07 19:03 ` Efraim Flashner
2018-05-08 13:24 ` Ludovic Courtès [this message]
2018-05-13 15:36 ` Efraim Flashner
2018-05-07 16:42 ` [bug#31342] [PATCH 1/2] gnu: enlightenment: Fix setuid program locations Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmdq46vo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31342@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.