From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fG2d4-0008RA-3k
	for guix-patches@gnu.org; Tue, 08 May 2018 09:26:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fG2d0-0007tG-6H
	for guix-patches@gnu.org; Tue, 08 May 2018 09:26:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45697)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fG2d0-0007t8-2G
	for guix-patches@gnu.org; Tue, 08 May 2018 09:26:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fG2cz-0004xI-Rx
	for guix-patches@gnu.org; Tue, 08 May 2018 09:26:01 -0400
Subject: [bug#31342] [PATCH 2/2] gnu: services: Add Enlightenment desktop
	service.
Resent-Message-ID: <handler.31342.B31342.152578591218990@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180502164723.13994-1-efraim@flashner.co.il>
	<20180502164723.13994-2-efraim@flashner.co.il>
	<87bmdr5s2g.fsf@gnu.org> <20180507190327.GA2707@macbook41>
Date: Tue, 08 May 2018 15:24:59 +0200
In-Reply-To: <20180507190327.GA2707@macbook41> (Efraim Flashner's message of
	"Mon, 7 May 2018 22:03:27 +0300")
Message-ID: <87bmdq46vo.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 31342@debbugs.gnu.org

Hello!

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Mon, May 07, 2018 at 06:49:43PM +0200, Ludovic Court=C3=A8s wrote:

[...]

>> Perhaps enlightenment_ckpasswd needs a PAM entry as well, like
>> =E2=80=98screen-locker-service-type=E2=80=99 does?
>>=20
>
> I'm not sure, enlightenment's screen locker code was refactored in
> 0.22.2 so that it would behave identically on Linux and BSD, and I'm not
> sure that the BSDs use PAM, and it seems to with as-is.

If you confirm it works as-is, that=E2=80=99s fine!

>> > +(define* (enlightenment-desktop-service
>> > +           #:key (config (enlightenment-desktop-configuration)))
>> > +  "Return a service that adds the @code{enlightenment} package to the=
 system
>> > +profile, and extends dbus with the ability for @code{efl} to generate
>> > +thumbnails and makes setuid the programs which enlightenment expects =
to have
>> > +their setuid bit set."
>> > +  (service enlightenment-desktop-service-type config))
>>=20
>> Not needed!  :-)
>>=20
>> Thank you,
>> Ludo=E2=80=99.
>
> I looked at the xfce service especially, and it actually has the same
> fields and declarations as enlightenment.

Sounds good.

> I'd like to leave the option in place to add
> '(enlightenment-desktop-service)' to an OS-config since it is then
> identical to the other desktop services we have.

This style has been (informally, I admit) deprecated since we introduced
the =E2=80=98service=E2=80=99 form.  The recommended way is to write:

  (service enlightenment-service-type)

I agree it=E2=80=99s slightly more verbose, but it=E2=80=99s more =E2=80=9C=
transparent.=E2=80=9D

Thanks,
Ludo=E2=80=99.