From: Ricardo Wurmus <rekado@elephly.net>
To: Christopher Baines <mail@cbaines.net>
Cc: 34240@debbugs.gnu.org
Subject: [bug#34240] [PATCH 4/5] gnu: Add system-config-printer.
Date: Tue, 29 Jan 2019 17:49:58 +0100 [thread overview]
Message-ID: <87bm3zpfwp.fsf@elephly.net> (raw)
In-Reply-To: <20190129114242.32481-4-mail@cbaines.net>
Christopher Baines <mail@cbaines.net> writes:
> * gnu/packages/gnome.scm (system-config-printer): New variable.
[…]
> + (arguments
> + `(#:imported-modules ((guix build python-build-system)
> + ,@%glib-or-gtk-build-system-modules)
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-Makefile.am
> + (lambda _
> + ;; The Makefile generates some scripts, so set a valid shebang
> + (substitute* "Makefile.am"
> + (("/bin/bash") (which "bash")))
> + #t))
[…]
> + (add-before 'configure 'bootstrap
> + (lambda _
> + ;; Run ./bootstrap as otherwise the build fails with
> + ;; automake-1.15: command not found
> + (invoke "./bootstrap")
> + #t))
The build system already provides a “bootstrap” phase, so maybe it would
be better to delete “configure” in “patch-Makefile.am” to activate the
bootstrap phase.
Otherwise looks good to me. Thanks!
--
Ricardo
next prev parent reply other threads:[~2019-01-29 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 11:37 [bug#34240] [PATCH 0/5] Gnome printing improvements Christopher Baines
2019-01-29 11:42 ` [bug#34240] [PATCH 1/5] gnu: Add cups-pk-helper Christopher Baines
2019-01-29 11:42 ` [bug#34240] [PATCH 2/5] services: " Christopher Baines
2019-01-29 16:44 ` Ricardo Wurmus
2019-01-29 16:56 ` Christopher Baines
2019-01-29 11:42 ` [bug#34240] [PATCH 3/5] gnu: Add python-pycups Christopher Baines
2019-01-29 16:44 ` Ricardo Wurmus
2019-01-29 11:42 ` [bug#34240] [PATCH 4/5] gnu: Add system-config-printer Christopher Baines
2019-01-29 16:49 ` Ricardo Wurmus [this message]
2019-02-13 8:21 ` bug#34240: " Christopher Baines
2019-01-29 11:42 ` [bug#34240] [PATCH 5/5] gnu: gnome: Include system-config-printer Christopher Baines
2019-01-29 16:50 ` Ricardo Wurmus
2019-01-29 16:42 ` [bug#34240] [PATCH 1/5] gnu: Add cups-pk-helper Ricardo Wurmus
2019-01-29 17:03 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm3zpfwp.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34240@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.