From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:58607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goXJo-0004dh-N2
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:37:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goXJn-0000Qf-JD
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:37:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51504)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1goXJm-0000PB-0o
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:37:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1goXJl-0000KF-Sa
	for guix-patches@gnu.org; Tue, 29 Jan 2019 12:37:01 -0500
Subject: [bug#34240] [PATCH 4/5] gnu: Add system-config-printer.
Resent-Message-ID: <handler.34240.B34240.15487833711188@debbugs.gnu.org>
References: <87a7jjr8y3.fsf@cbaines.net>
	<20190129114242.32481-1-mail@cbaines.net>
	<20190129114242.32481-4-mail@cbaines.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190129114242.32481-4-mail@cbaines.net>
Date: Tue, 29 Jan 2019 17:49:58 +0100
Message-ID: <87bm3zpfwp.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34240@debbugs.gnu.org


Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/gnome.scm (system-config-printer): New variable.
[=E2=80=A6]
> +    (arguments
> +     `(#:imported-modules ((guix build python-build-system)
> +                           ,@%glib-or-gtk-build-system-modules)
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-Makefile.am
> +           (lambda _
> +             ;; The Makefile generates some scripts, so set a valid sheb=
ang
> +             (substitute* "Makefile.am"
> +               (("/bin/bash") (which "bash")))
> +             #t))
[=E2=80=A6]
> +         (add-before 'configure 'bootstrap
> +           (lambda _
> +             ;; Run ./bootstrap as otherwise the build fails with
> +             ;; automake-1.15: command not found
> +             (invoke "./bootstrap")
> +             #t))

The build system already provides a =E2=80=9Cbootstrap=E2=80=9D phase, so m=
aybe it would
be better to delete =E2=80=9Cconfigure=E2=80=9D in =E2=80=9Cpatch-Makefile.=
am=E2=80=9D to activate the
bootstrap phase.

Otherwise looks good to me.  Thanks!

--
Ricardo