From: Ricardo Wurmus <rekado@elephly.net>
To: pkill9@runbox.com
Cc: 34497 <34497@debbugs.gnu.org>
Subject: [bug#34497] Add odamex
Date: Wed, 20 Feb 2019 21:47:00 +0100 [thread overview]
Message-ID: <87bm365gsb.fsf@elephly.net> (raw)
In-Reply-To: <E1gvNRB-0003UF-5z@rmmprod05.runbox>
Hi pkill9,
> * gnu/packages/games.scm (odamex): New variable.
[…]
> + (uri (string-append
> + "mirror://sourceforge/odamex/Odamex/"
> + version
> + "/odamex-src-"
> + version
> + ".tar.gz"))
Please put this on fewer lines.
> + (sha256
> + (base32
> + "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> + (build-system cmake-build-system)
> + (arguments `(#:tests? #f)) ;; No tests
Please use just one semicolon.
> + (inputs
> + `(("sdl" ,(@ (gnu packages sdl) sdl))
> + ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> + ("zlib" ,(@ (gnu packages compression) zlib))
> + ("libpng" ,(@ (gnu packages image) libpng))
> + ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))
This is not okay. Please just use the plain variable names.
> + (home-page "https://odamex.net/")
> + (synopsis "Multiplayer Doom port")
> + (description "Odamex is a free, cross-platform modification of the Doom
> +engine that allows players to easily join servers dedicated to playing Doom
> +online.")
Please remove “free” — all software in Guix is Free Software.
> + (license license:gpl2)))
Looks like this is actually gpl2+ as evidenced by files like this:
https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L12
Could you please send an updated patch?
--
Ricardo
next prev parent reply other threads:[~2019-02-20 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 6:04 [bug#34497] Add odamex pkill9
2019-02-17 10:25 ` Efraim Flashner
2019-02-17 14:28 ` pkill9
2019-02-20 20:47 ` Ricardo Wurmus [this message]
2019-02-21 13:04 ` pkill9
2019-03-23 20:57 ` bug#34497: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm365gsb.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34497@debbugs.gnu.org \
--cc=pkill9@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.