From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:42304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwYmn-0001ux-5a
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:48:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwYmh-0006PU-5K
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:48:05 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57849)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gwYmg-0006Im-HQ
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:48:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwYmg-000451-6W
	for guix-patches@gnu.org; Wed, 20 Feb 2019 15:48:02 -0500
Subject: [bug#34497] Add odamex
Resent-Message-ID: <handler.34497.B34497.155069564715637@debbugs.gnu.org>
References: <E1gut54-0006bR-0W@rmmprod05.runbox>
	<20190217102541.GB7206@macbook41> <E1gvNRB-0003UF-5z@rmmprod05.runbox>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <E1gvNRB-0003UF-5z@rmmprod05.runbox>
Date: Wed, 20 Feb 2019 21:47:00 +0100
Message-ID: <87bm365gsb.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: pkill9@runbox.com
Cc: 34497 <34497@debbugs.gnu.org>


Hi pkill9,

> * gnu/packages/games.scm (odamex): New variable.
[=E2=80=A6]
> +       (uri (string-append
> +             "mirror://sourceforge/odamex/Odamex/"
> +             version
> +             "/odamex-src-"
> +             version
> +             ".tar.gz"))

Please put this on fewer lines.

> +       (sha256
> +        (base32
> +         "1sh6lqj7vsdmnqz17hw0b6vy7xx6dp41k2sdw99ympsfa2xd1d2j"))))
> +    (build-system cmake-build-system)
> +    (arguments `(#:tests? #f)) ;; No tests

Please use just one semicolon.

> +    (inputs
> +     `(("sdl" ,(@ (gnu packages sdl) sdl))
> +       ("sdl-mixer" ,(@ (gnu packages sdl) sdl-mixer))
> +       ("zlib" ,(@ (gnu packages compression) zlib))
> +       ("libpng" ,(@ (gnu packages image) libpng))
> +       ("alsa-lib" ,(@ (gnu packages linux) alsa-lib))))

This is not okay.  Please just use the plain variable names.

> +    (home-page "https://odamex.net/")
> +    (synopsis "Multiplayer Doom port")
> +    (description "Odamex is a free, cross-platform modification of the D=
oom
> +engine that allows players to easily join servers dedicated to playing D=
oom
> +online.")

Please remove =E2=80=9Cfree=E2=80=9D =E2=80=94 all software in Guix is Free=
 Software.

> +    (license license:gpl2)))

Looks like this is actually gpl2+ as evidenced by files like this:

    https://github.com/odamex/odamex/blob/master/server/src/d_netinfo.cpp#L=
12

Could you please send an updated patch?

--=20
Ricardo