From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 39767@debbugs.gnu.org
Subject: [bug#39767] [PATCH core-updates] gnu: ld-wrapper: Preserve quoted arguments from response files.
Date: Mon, 24 Feb 2020 22:14:35 +0100 [thread overview]
Message-ID: <87blpn4ric.fsf@devup.no> (raw)
In-Reply-To: <87zhd7em2i.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Marius!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> * gnu/packages/ld-wrapper.in (expand-arguments): Add TOKENIZE procedure, and
>> use that to parse the response file.
>
> LGTM!
>
>> Currently the ld-wrapper will fail inscrutably if a response file
>> contains double quotes. This patch fixes that, and also preserves
>> whitespaces between quotes.
>
> Out of curiosity, where did you stumble upon response files with quotes?
> Was it GHC?
A variant of this wrapper will (hopefully!) soon show up on the 'master'
branch, required for version 80 of ungoogled-chromium. It generates
response files where all "-lfoo" "-lbar" arguments are quoted, even
though they contain no spaces.
Thanks for the quick review, will merge it on core-updates after it hits
'master'. :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-02-24 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 16:01 [bug#39767] [PATCH core-updates] gnu: ld-wrapper: Preserve quoted arguments from response files Marius Bakke
2020-02-24 21:01 ` Ludovic Courtès
2020-02-24 21:14 ` Marius Bakke [this message]
2020-03-06 12:26 ` bug#39767: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blpn4ric.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=39767@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.