From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:55593) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6L4B-0005NQ-2S for guix-patches@gnu.org; Mon, 24 Feb 2020 16:15:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6L4A-0005h6-24 for guix-patches@gnu.org; Mon, 24 Feb 2020 16:15:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6L49-0005h0-U8 for guix-patches@gnu.org; Mon, 24 Feb 2020 16:15:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j6L49-0005Xp-Pz for guix-patches@gnu.org; Mon, 24 Feb 2020 16:15:01 -0500 Subject: [bug#39767] [PATCH core-updates] gnu: ld-wrapper: Preserve quoted arguments from response files. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87zhd7em2i.fsf@gnu.org> References: <20200224160132.21037-1-mbakke@fastmail.com> <87zhd7em2i.fsf@gnu.org> Date: Mon, 24 Feb 2020 22:14:35 +0100 Message-ID: <87blpn4ric.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 39767@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Marius! > > Marius Bakke skribis: > >> * gnu/packages/ld-wrapper.in (expand-arguments): Add TOKENIZE procedure,= and >> use that to parse the response file. > > LGTM! > >> Currently the ld-wrapper will fail inscrutably if a response file >> contains double quotes. This patch fixes that, and also preserves >> whitespaces between quotes. > > Out of curiosity, where did you stumble upon response files with quotes? > Was it GHC? A variant of this wrapper will (hopefully!) soon show up on the 'master' branch, required for version 80 of ungoogled-chromium. It generates response files where all "-lfoo" "-lbar" arguments are quoted, even though they contain no spaces. Thanks for the quick review, will merge it on core-updates after it hits 'master'. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl5UPLsACgkQoqBt8qM6 VPpIsQf9Fp51cJnm9O68dnVAnyQEpbZeiTRlBut5BaIirnUuQzGD2LyF1dWqbo+V dJLy1ydj5hqUAOvyd+SNQFnDOJRcLnpfj199ksOcUG6+/Qh395eYDd9niulNu8og OLr2y9M5QBGzcClOXLaHkQKEF/yb2PStOWEocziLh7+bTTJvwWMW16uazYbPbIH1 e2xqYYdykLfWiVsy01sz1TqF4/RZ4qlMK6SHyIWd+/QUe+sDeecsrrOFLYZJVYNg sCphT+Dq1cMXYH6Ys9wwQGY4udExxN07YmewAyfH1/Xws033fcfGBsJ+G0FkMS4h pQbeInGGGDQHbXoWa8bnuODNNDaZwg== =k0Ny -----END PGP SIGNATURE----- --=-=-=--