From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Morgan.J.Smith@outlook.com
Cc: 44249@debbugs.gnu.org
Subject: [bug#44249] [PATCH] gnu: emacs: Make strip-double-wrap more robust
Date: Tue, 27 Oct 2020 22:13:29 +0100 [thread overview]
Message-ID: <87blgn4bk6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <DM5PR1001MB21059362E2A281295A7FA2B2C5160@DM5PR1001MB2105.namprd10.prod.outlook.com> (Morgan J. Smith's message of "Mon, 26 Oct 2020 22:01:45 -0400")
Hello,
Morgan.J.Smith@outlook.com writes:
> * gnu/packages/emacs.scm (emacs) [strip-double-wrap]:
> Use regex to find emacs executable. This works even when the version is
> changed by package transformations (ex: version=git.master)
Thank you.
> + (copy-file
> + (car
Please use pattern matching, i.e. `match', instead of `car'.
> + (find-files
> + "bin" (file-name-predicate "^emacs-([0-9]+\\.)+[0-9]+$")))
> + "bin/emacs")
Would it be even more robust to simply catch any "emacs-" prefixed file
name?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-27 21:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 2:01 [bug#44249] [PATCH] gnu: emacs: Make strip-double-wrap more robust Morgan.J.Smith
2020-10-27 21:13 ` Nicolas Goaziou [this message]
2020-11-02 4:35 ` [bug#44249] [PATCH v2] " Morgan.J.Smith
2020-11-03 9:45 ` bug#44249: " Nicolas Goaziou
2020-11-03 12:48 ` [bug#44249] " Nicolas Goaziou
2020-11-03 14:49 ` Morgan Smith
2020-11-03 21:38 ` Nicolas Goaziou
2020-11-03 22:09 ` zimoun
2020-11-04 19:47 ` [bug#44249] [PATCH v3] " Morgan.J.Smith
2020-11-05 22:33 ` Nicolas Goaziou
2020-11-07 20:48 ` Marius Bakke
2021-01-15 13:28 ` [bug#44249] [PATCH] " Ludovic Courtès
2021-01-15 19:49 ` Morgan Smith
2021-01-16 21:54 ` Ludovic Courtès
2021-01-16 22:03 ` Morgan Smith
2021-01-31 20:30 ` bug#44249: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blgn4bk6.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=44249@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.