From: "Ludovic Courtès" <ludo@gnu.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: 44249@debbugs.gnu.org
Subject: [bug#44249] [PATCH] gnu: emacs: Make strip-double-wrap more robust
Date: Sat, 16 Jan 2021 22:54:29 +0100 [thread overview]
Message-ID: <875z3wy2cq.fsf_-_@gnu.org> (raw)
In-Reply-To: <MWHPR0801MB36758C2C15729A54EB8409CEC5A70@MWHPR0801MB3675.namprd08.prod.outlook.com> (Morgan Smith's message of "Fri, 15 Jan 2021 14:49:15 -0500")
Hi,
Morgan Smith <Morgan.J.Smith@outlook.com> skribis:
> I've actually been sorta half working on this for a while now.
>
> The problem is exactly that the modules field is inherited. See each
> build system includes its own module in the modules field. The various
> emacsen are built with different build systems. So emacs is going to
> need to import (guix build glib-or-gtk-build-system) and emacs-minimal
> is going to want (guix build gnu-build-system). By setting the modules
> to be the glib-or-gtk-build-system, we override the default modules in
> each inherited package. This means building emacs-minimal would result
> in this error:
>
> no code for module (guix build glib-or-gtk-build-system)
Ooh, my bad, I had completely overlooked this “detail”.
Then I guess the patch is fine though… in this case you could
exceptionally ;-) write (car (find-files …)) so you don’t even need to
both importing (ice-9 match). That’d save quite a few lines of code.
WDYT?
Thanks!
Ludo’.
next prev parent reply other threads:[~2021-01-16 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 2:01 [bug#44249] [PATCH] gnu: emacs: Make strip-double-wrap more robust Morgan.J.Smith
2020-10-27 21:13 ` Nicolas Goaziou
2020-11-02 4:35 ` [bug#44249] [PATCH v2] " Morgan.J.Smith
2020-11-03 9:45 ` bug#44249: " Nicolas Goaziou
2020-11-03 12:48 ` [bug#44249] " Nicolas Goaziou
2020-11-03 14:49 ` Morgan Smith
2020-11-03 21:38 ` Nicolas Goaziou
2020-11-03 22:09 ` zimoun
2020-11-04 19:47 ` [bug#44249] [PATCH v3] " Morgan.J.Smith
2020-11-05 22:33 ` Nicolas Goaziou
2020-11-07 20:48 ` Marius Bakke
2021-01-15 13:28 ` [bug#44249] [PATCH] " Ludovic Courtès
2021-01-15 19:49 ` Morgan Smith
2021-01-16 21:54 ` Ludovic Courtès [this message]
2021-01-16 22:03 ` Morgan Smith
2021-01-31 20:30 ` bug#44249: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z3wy2cq.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=44249@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.