From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Attila Lendvai <attila@lendvai.name>
Cc: 50751@debbugs.gnu.org
Subject: [bug#50751] [PATCH 1/2] gnu: python-trezor-agent: Fix key generation with trezor-gpg init
Date: Wed, 01 Dec 2021 16:34:20 +0100 [thread overview]
Message-ID: <87bl20z6df.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <Hs77H2cXyqPW_nJgfTO0nL8x8rsO3f_B7RXpm7izFoLwDagvbu_gbF2ovCjsKDQoWSIhVtKONEsm_juwoVk3ExzV2vUM9uJQwYL1nxXdXjw=@lendvai.name> (Attila Lendvai's message of "Tue, 30 Nov 2021 20:51:11 +0000")
Hello,
Attila Lendvai <attila@lendvai.name> writes:
> ouch, i already had a newer version of the patchset locally.
> i reported an issue upstream, and they got rid of the argv[0] usage,
> and also made a new release.
It happens.
>
> i was already testing it locally but then life happened before i could
> send it. i have sent the new patchset now:
> https://issues.guix.gnu.org/52207
Great.
> re splitting the commit: i don't think it's a good idea, mostly due to
> git bisect: pushing commits that may not even compile can make
> someone's life much harder down the road. i think updating tightly
> interdependent packages should happen in one commit, so that each git
> commit leaves the repo in a functional state, and so that it can
> compile and run the test suite.
>
> but in spite of the above, i have sent the new patchset as separate
> commits.
I overlooked the fact that packages were interdependent, which is pretty
obvious now you mention it. In that case, I agree splitting the commit
was not a good idea.
So... could you send the new patchset again in a single commit?
Thanks,
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2021-12-01 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:30 [bug#50751] [PATCH] gnu: update Trezor support Attila Lendvai
2021-09-23 18:35 ` Sarah Morgensen
2021-09-24 11:05 ` Attila Lendvai
2021-09-24 11:05 ` [bug#50751] [PATCH 1/2] gnu: python-trezor-agent: Fix key generation with trezor-gpg init Attila Lendvai
2021-09-24 11:05 ` [bug#50751] [PATCH 2/2] gnu: update Trezor support Attila Lendvai
2021-11-28 20:35 ` bug#50751: " Nicolas Goaziou
2021-11-28 20:34 ` [bug#50751] [PATCH 1/2] gnu: python-trezor-agent: Fix key generation with trezor-gpg init Nicolas Goaziou
2021-11-30 20:51 ` Attila Lendvai
2021-12-01 15:34 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl20z6df.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=50751@debbugs.gnu.org \
--cc=attila@lendvai.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.