From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kLwACDaWp2EShQEAgWs5BA (envelope-from ) for ; Wed, 01 Dec 2021 16:35:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gOG4AzaWp2H5OAAA1q6Kng (envelope-from ) for ; Wed, 01 Dec 2021 15:35:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB52E29A01 for ; Wed, 1 Dec 2021 16:35:17 +0100 (CET) Received: from localhost ([::1]:33686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msRdd-0002SY-0Y for larch@yhetil.org; Wed, 01 Dec 2021 10:35:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msRdO-0002SO-6r for guix-patches@gnu.org; Wed, 01 Dec 2021 10:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msRdN-0007CW-VW for guix-patches@gnu.org; Wed, 01 Dec 2021 10:35:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msRdN-0004bd-T7 for guix-patches@gnu.org; Wed, 01 Dec 2021 10:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50751] [PATCH 1/2] gnu: python-trezor-agent: Fix key generation with trezor-gpg init Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 Dec 2021 15:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50751 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 50751@debbugs.gnu.org Received: via spool by 50751-submit@debbugs.gnu.org id=B50751.163837287217654 (code B ref 50751); Wed, 01 Dec 2021 15:35:01 +0000 Received: (at 50751) by debbugs.gnu.org; 1 Dec 2021 15:34:32 +0000 Received: from localhost ([127.0.0.1]:45133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msRcu-0004ag-3o for submit@debbugs.gnu.org; Wed, 01 Dec 2021 10:34:32 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msRcs-0004aR-87 for 50751@debbugs.gnu.org; Wed, 01 Dec 2021 10:34:31 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id DB81AFF802; Wed, 1 Dec 2021 15:34:21 +0000 (UTC) From: Nicolas Goaziou References: <20210923083045.10372-1-attila@lendvai.name> <20210924110506.4676-1-attila@lendvai.name> <87y258nhn8.fsf@nicolasgoaziou.fr> Date: Wed, 01 Dec 2021 16:34:20 +0100 In-Reply-To: (Attila Lendvai's message of "Tue, 30 Nov 2021 20:51:11 +0000") Message-ID: <87bl20z6df.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638372917; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=wnf4qAOzEEmZlWIC6KnRVDggc235ez/h8oWIfKemoIs=; b=UftRZzNbNIofLYrNz0tN+2HOhsruFsBWK3f7N0OHjrClVvM7C2vPsT7jFDSfwG0yfZVKb2 wh69nL1BHCRbBql+UAEgptqexECAf9VXf3DhWbJknXLqMiQbrpji19c02MrOWBi1YnmIWo C7SPWcLM9WBgn+oU6aA4Jh7v/r51BbZ55SzCuamI3uYACr5ll5U23nCjL2TBxQhsN+6w1j VrxVfcdaihkfWdwhuS0DXAcrGx0hHAHxn/IZ8rPSskiXiaRMjZD6haaHnvVriqiTSC9wF+ pg4nw9AWNhA6bmUKXDKpmGk2M37n/6+oRDSFoBn1Tj7gEhgYvu2KOeCmPmyvfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638372917; a=rsa-sha256; cv=none; b=uf5TlFhqg7HFh7AJgaKL1HDr63VkSFVKZMpaRptwphzKCZqr9RuhKohloSuCyxtNhO6gIu vmRzlfGJkL3Up2MpA0N3go/lgxHIZI+v2U2sgZaRBsAvWnHAVA8ryznIW5k9Vdp3UQHfIc xSXIQkLgcId0iix0X2MsHseVb1zfnBNrjrXe+/JH8BsohBl3ppdnkICJR9JRZ/sAIavbG2 p+AvxMR7JHYCYzkEHniOIX1H6eLns5A/3qqYWOAiKbyNJ8T3bE6n+hk9qG6StDBD69CO/e N+pz9EjCCqMKexYR2JNAUmzpjQ5Cj+zXXexr8RmUQl4iGthCOcWQadRHQF9Fkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DB52E29A01 X-Spam-Score: -3.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: zmvp/deg5JmO Hello, Attila Lendvai writes: > ouch, i already had a newer version of the patchset locally. > i reported an issue upstream, and they got rid of the argv[0] usage, > and also made a new release. It happens. > > i was already testing it locally but then life happened before i could > send it. i have sent the new patchset now: > https://issues.guix.gnu.org/52207 Great. > re splitting the commit: i don't think it's a good idea, mostly due to > git bisect: pushing commits that may not even compile can make > someone's life much harder down the road. i think updating tightly > interdependent packages should happen in one commit, so that each git > commit leaves the repo in a functional state, and so that it can > compile and run the test suite. > > but in spite of the above, i have sent the new patchset as separate > commits. I overlooked the fact that packages were interdependent, which is pretty obvious now you mention it. In that case, I agree splitting the commit was not a good idea. So... could you send the new patchset again in a single commit? Thanks, Regards, -- Nicolas Goaziou