From: "Ludovic Courtès" <ludo@gnu.org>
To: "Antoine R. Dumont (@ardumont)" <antoine.romain.dumont@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: File search
Date: Mon, 19 Dec 2022 22:25:01 +0100 [thread overview]
Message-ID: <87bknzccia.fsf@gnu.org> (raw)
In-Reply-To: <87pmck7g6y.fsf@gmail.com> (Antoine R. Dumont's message of "Thu, 15 Dec 2022 18:03:01 +0100")
Hi Antoine!
"Antoine R. Dumont (@ardumont)" <antoine.romain.dumont@gmail.com>
skribis:
> Here is the rough changelog:
>
> - The local db cache is now versioned. Migration will transparently
> happen for users at each index command calls (if need be).
Perfect!
> - The cli parsing got rewritten to be more flexible (inspired from
> existing code from guix, notably `guix home`).
>
> - We can now choose the indexation method using the
> `--with-method={store|manifests}` flag. The "manifests" method is the
> default, seel the help message for more details).
Excellent. (I think we can call it ‘--method’, without “with”.)
> - Finally, the indexation methods are displayed using a progress bar.
Yay, I love progress bars. :-)
> Heads up, I did not yet address the "output" part. Thanks @zimoun for
> the clarification btw ;)
Future work. ;-)
>> In the package case, the number of packages is known ahead.
>
> @civodul For the index 'store' implementation, ^ I did not find that
> information.
(length (all-packages)) gives you the total number of packages you’re
going to traverse. ‘all-packages’ is not instantaneous, but as a good
approximation the time spent in ‘all-packages’ can be ignored.
> So, as a costly implementation detail, I'm folding over all packages
> first to know the total number of packages (for the progress bar). And
> then another round trip to actually do the insert.
You could build up the package list just once and call ‘length’ on it.
> Hope you'll find it mostly to your taste!
I do!
> Note: I gather we'll rework the commits at some point (when it's ready)
> so I did not bother too much right now.
I think at this point we could consider integration in Guix proper,
under ‘guix/scripts’. For that we could dismiss commit history.
That’ll entail extra work (d’oh!) such as fine-tuning, writing tests,
and writing a section for the manual.
The other option, if you prefer, would be to keep it in a separate repo
as an extension that people can install. To me that would be more of a
temporary solution because I think it’s a useful feature that ought to
be provided by Guix proper eventually.
WDYT? :-)
Ludo’.
next prev parent reply other threads:[~2022-12-19 21:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 17:58 File search antoine.romain.dumont
2022-12-02 18:22 ` Antoine R. Dumont (@ardumont)
2022-12-03 18:19 ` Ludovic Courtès
2022-12-04 16:35 ` Antoine R. Dumont (@ardumont)
2022-12-06 10:01 ` Ludovic Courtès
2022-12-06 12:59 ` zimoun
2022-12-06 18:27 ` (
2022-12-08 15:41 ` Ludovic Courtès
2022-12-09 10:05 ` Antoine R. Dumont (@ardumont)
2022-12-09 18:05 ` zimoun
2022-12-11 10:22 ` Ludovic Courtès
2022-12-15 17:03 ` Antoine R. Dumont (@ardumont)
2022-12-19 21:25 ` Ludovic Courtès [this message]
2022-12-19 22:44 ` zimoun
2022-12-20 11:13 ` Antoine R. Dumont (@ardumont)
-- strict thread matches above, loose matches on Subject: below --
2022-01-21 9:03 Ludovic Courtès
2022-01-21 10:35 ` Mathieu Othacehe
2022-01-22 0:35 ` Ludovic Courtès
2022-01-21 19:00 ` Vagrant Cascadian
2022-01-22 0:37 ` Ludovic Courtès
2022-01-22 2:53 ` Maxim Cournoyer
2022-01-25 11:15 ` Ludovic Courtès
2022-01-25 11:20 ` Oliver Propst
2022-01-25 11:22 ` Oliver Propst
2022-01-22 4:46 ` raingloom
2022-01-22 7:55 ` Ricardo Wurmus
2022-01-24 15:48 ` Ludovic Courtès
2022-01-24 17:03 ` Ricardo Wurmus
2022-02-02 16:14 ` Maxim Cournoyer
2022-02-05 11:15 ` Ludovic Courtès
2022-01-25 23:45 ` Ryan Prior
2022-02-05 11:18 ` Ludovic Courtès
2022-02-06 13:27 ` André A. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bknzccia.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=antoine.romain.dumont@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.