From: Maxime Devos <maximedevos@telenet.be>
To: Christopher Rodriguez <yewscion@gmail.com>, 55814@debbugs.gnu.org
Subject: [bug#55814] [PATCH v2] Updated python-flake8 and inputs to reenable build.
Date: Mon, 06 Jun 2022 20:33:44 +0200 [thread overview]
Message-ID: <87bd42fbfea63b89c0abd932986ad69b764e34ac.camel@telenet.be> (raw)
In-Reply-To: <20220606172432.363385-1-yewscion@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]
Christopher Rodriguez schreef op ma 06-06-2022 om 13:24 [-0400]:
> ---
>
> Maxime,
>
> Thanks for the feedback! Sorry for missing something so basic.
>
> I swapped both of the `if` statements with `when` statements, as they are more
> semantically appropriate here anyway.
>
> I also fixed a mistake I found in the lambda call (#:keys instead of #:key), and
> uploaded the current version of `python-flake8` (4.0.1) to the software heritage
> project. I'm waiting for the save to go through, but after that, the linter will
> return no errors.
>
> gnu/packages/python-xyz.scm | 54 ++++++++++++++++++-------------------
> 1 file changed, 26 insertions(+), 28 deletions(-)
Only a single independent change per patch, otherwise LGTM, haven't
looked at the source diff or build it though. On Software Heritage:
IIUC, saving something on SWH is not something you can do as individual
(except for git repos), rather, SWH asks a Guix server what sources are
used by packages. So effectively SWH will wait for the patch to be
applied before archiving it unless I'm misunderstanding things.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-06-06 18:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 1:43 [bug#55814] [PATCH] Updated python-flake8 and inputs to reenable build Christopher Rodriguez
2022-06-06 6:13 ` Liliana Marie Prikler
2022-06-06 9:31 ` Maxime Devos
2022-06-06 17:24 ` [bug#55814] [PATCH v2] " Christopher Rodriguez
2022-06-06 18:33 ` Maxime Devos [this message]
[not found] ` <pkmp4e1qw11v98.fsf@crane.ant.amazon.com>
2022-06-06 19:05 ` Maxime Devos
2022-06-07 1:10 ` [bug#55814] [PATCH v3 1/8] Refreshed `python-pycodestyle` to version 2.8.0 Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 2/8] Refreshed `python-flake8` to 4.0.1 Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 3/8] `python-pycodestyle` now respects `#:tests?` Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 4/8] `python-flake8` now supports `#:tests?` Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 5/8] Added `python-pyflakes-2.3` as a variant package Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 6/8] Added `python-pycodestyle-2.7` " Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 7/8] Added `python-flake8-3.9` " Christopher Rodriguez
2022-06-07 1:10 ` [bug#55814] [PATCH v3 8/8] Formatted Code with `guix style` Christopher Rodriguez
2022-06-07 1:12 ` [bug#55814] Status of Rebuilds for Change Christopher Rodriguez
2022-06-07 13:22 ` bug#55814: [PATCH] Updated python-flake8 and inputs to reenable build Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bd42fbfea63b89c0abd932986ad69b764e34ac.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55814@debbugs.gnu.org \
--cc=yewscion@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.