From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iGTQJK9InmIpawAAbAwnHQ (envelope-from ) for ; Mon, 06 Jun 2022 20:34:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AJSwJK9InmKERQAAauVa8A (envelope-from ) for ; Mon, 06 Jun 2022 20:34:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 67C0B3DE0F for ; Mon, 6 Jun 2022 20:34:18 +0200 (CEST) Received: from localhost ([::1]:41468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyHYP-0003rY-0X for larch@yhetil.org; Mon, 06 Jun 2022 14:34:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyHYA-0003px-VG for guix-patches@gnu.org; Mon, 06 Jun 2022 14:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyHYA-0005Ia-ML for guix-patches@gnu.org; Mon, 06 Jun 2022 14:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyHYA-0000kt-Gc for guix-patches@gnu.org; Mon, 06 Jun 2022 14:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55814] [PATCH v2] Updated python-flake8 and inputs to reenable build. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Jun 2022 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Rodriguez , 55814@debbugs.gnu.org Received: via spool by 55814-submit@debbugs.gnu.org id=B55814.16545404292884 (code B ref 55814); Mon, 06 Jun 2022 18:34:02 +0000 Received: (at 55814) by debbugs.gnu.org; 6 Jun 2022 18:33:49 +0000 Received: from localhost ([127.0.0.1]:36871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyHXx-0000kS-3b for submit@debbugs.gnu.org; Mon, 06 Jun 2022 14:33:49 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:49740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyHXu-0000kI-Kx for 55814@debbugs.gnu.org; Mon, 06 Jun 2022 14:33:46 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id fuZk270074UW6Th06uZkZo; Mon, 06 Jun 2022 20:33:44 +0200 Message-ID: <87bd42fbfea63b89c0abd932986ad69b764e34ac.camel@telenet.be> From: Maxime Devos Date: Mon, 06 Jun 2022 20:33:44 +0200 In-Reply-To: <20220606172432.363385-1-yewscion@gmail.com> References: <20220606014315.280227-1-yewscion@gmail.com> <20220606172432.363385-1-yewscion@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-s3OhYMz19dADHPngoDSE" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1654540424; bh=zYCGnBXIdQMSJ3jZguDLTPsAZnBeqIEwhC+H5tQXk7s=; h=Subject:From:To:Date:In-Reply-To:References; b=leQQoZJoNJy4vm+RzhRRxBwUdRxravqBVu6x0Gz2gHnNgY4kuvk6nOQLlAplRrulJ YrqEj2mP/Nuev+Yg75PwAdJ6qX2kU6TficFbr6U2es2HvHPZQ24exw2jxGzERZ3p6k GQ8KDIdiNb9/JuuXUNcJSdAdDWohVyksLAjJuFw0Oo8YZBCi6yC44EkBuaLC5ao9j8 vPtTooHUYmm1bZp1q0C3lEbM4atjhetKWblyGiOd7EOkSEXjtqZ7HUqgQT1XKpj0gV eTDcr4eZc1LGlsaXmKy+uyp1MmH8sVjRHTTiuKso52AO5t5HDwFD3YYOOUHk0e0TJg 9k8iy/hujvSgg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654540458; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zYCGnBXIdQMSJ3jZguDLTPsAZnBeqIEwhC+H5tQXk7s=; b=E+SHPhXLy24DmztJMgy2gG/5QmDLRTthkex8ia2S3NcUU+kWrTk0ej/55YgCmWBK4Rsq9c BTA6w29AhQmVi0JVgfjtwcsjmBngOFvKb43HbJfnlM0X/qK3Ko63DcX44i46ptczWqkAZ5 QJWckm5SL/Jg/sxbJNrE0qVVgszu77tB8VnDLKdWy2FQaw0jBzhftbcNGW+ow/HxL1m7Jo FpFF3rTbwpbtANSOP4erpX1kK/4Q3MzuIT2Q+d3ONOsjUvAN+F14HKs1AiQEv9igXO7XBG /T34uvdOaS9BDJ3Wk4u8Q7XzFPw+JHrLQmXyv03GjnKF5YJtRz2idAwTvwlvBA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654540458; a=rsa-sha256; cv=none; b=T1hHcgGxvbLetAcLI56IIao9hcbjzMNEgTGGlos8Jh0O1oi5JUNvgZvROFRcmrn1YyBTXr TEYqTyQvEytdEEypOvvwpowYt6dhpCEn7ZsAetda0LWeDoiTtYWoMYICYatmODWhlwiy4/ W32w84YWHOrWVUUlOqLDZCzKqDfu5IZU6heB2E9llyldIEd45RPCniFaJrpx15LixwpSWF At3jIT4Ptv4jzD/zu6eozrIHph9b/g6M5FCSSVQywRwinkNGhQffh8NjDOlWZ8+7GfA+n6 rHbXrhLsh2uhRkLarEpRQ7ZXu9/Z8bS80pBrQjnrpoa2stZ0zjlTht8ryNd+vg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=leQQoZJo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.89 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=leQQoZJo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 67C0B3DE0F X-Spam-Score: 3.89 X-Migadu-Scanner: scn1.migadu.com X-TUID: rsRottbQCdqc --=-s3OhYMz19dADHPngoDSE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Christopher Rodriguez schreef op ma 06-06-2022 om 13:24 [-0400]: > --- >=20 > Maxime, >=20 > Thanks for the feedback! Sorry for missing something so basic. >=20 > I swapped both of the `if` statements with `when` statements, as they are= more > semantically appropriate here anyway. >=20 > I also fixed a mistake I found in the lambda call (#:keys instead of #:ke= y), and > uploaded the current version of `python-flake8` (4.0.1) to the software h= eritage > project. I'm waiting for the save to go through, but after that, the lint= er will > return no errors. >=20 > =C2=A0gnu/packages/python-xyz.scm | 54 ++++++++++++++++++----------------= --- > =C2=A01 file changed, 26 insertions(+), 28 deletions(-) Only a single independent change per patch, otherwise LGTM, haven't looked at the source diff or build it though. On Software Heritage: IIUC, saving something on SWH is not something you can do as individual (except for git repos), rather, SWH asks a Guix server what sources are used by packages. So effectively SWH will wait for the patch to be applied before archiving it unless I'm misunderstanding things. Greetings, Maxime. --=-s3OhYMz19dADHPngoDSE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYp5IiBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7uv9AQDwigLNaYI8mTyBlyRe2bq1++/Q 5sIjdOK+hLkvTW9YsgD/bkS8ms8wHqGz8nBbleB+5Pe0SJJxPk5+b95SQMy5ggE= =PgDB -----END PGP SIGNATURE----- --=-s3OhYMz19dADHPngoDSE--