all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: "Gábor Boskovits" <boskovits@gmail.com>, 29896@debbugs.gnu.org
Subject: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 13:13:54 +0100	[thread overview]
Message-ID: <87a7xa6o71.fsf@elephly.net> (raw)
In-Reply-To: <87y3kuf9u1.fsf@gmail.com>


Chris Marusich <cmmarusich@gmail.com> writes:

> Gábor Boskovits <boskovits@gmail.com> writes:
>
>> Actually I did forget to check if it is used runtime.
>> It is used to build and OSGi bundle.
>> At first I tried to fake the dependency like for the ant tasks,
>> but I got compilation errors.
>
> If the new input is also required at runtime, then I'm not sure this
> package definition is correct.  I would normally expect a "runtime
> dependency" to be either retained as a reference in the output, or
> declared as a propagated-input (so that it gets installed alongside this
> package when this package is installed into a profile).  Perhaps I am
> missing some information here.
>
> I'm hoping Ricardo can comment on how this is intended to work for Java
> packages, since he originally added the ant-build-system.

The jars that the ant-build-system generates are uncompressed and thus
allow the scanner to find embedded store references.  The problem seems
to be that references to other *jars* are not kept, because they are
never recorded anywhere.  That’s normal for Java, which looks for named
classes on the classpath, i.e. a list of jars.  It behaves very much
like Python and its PYTHONPATH in this regard.

The best we can do here is to propagate inputs.  The alternative is to
try to be smart and record the effective runtime classpath, but that’s
hard/impossible to get right.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  reply	other threads:[~2018-01-22 20:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 19:00 [bug#29896] [PATCH core-updates] gnu: java-asm: Update to 6.0 Gábor Boskovits
2018-01-07 21:23 ` [bug#29896] [PATCH] " Gábor Boskovits
2018-01-07 21:27   ` Gábor Boskovits
2018-01-19  6:35   ` Chris Marusich
2018-01-19  8:11     ` Gábor Boskovits
2018-01-19  9:59       ` Chris Marusich
2018-01-19 12:13         ` Ricardo Wurmus [this message]
2018-01-20  0:12     ` Leo Famulari
2018-01-20  7:50       ` Chris Marusich
2018-01-20  9:08         ` Gábor Boskovits
2018-01-20 11:24           ` Julien Lepiller
2018-01-20 21:43           ` bug#29896: " Chris Marusich
2018-01-21 13:52             ` [bug#29896] " Ricardo Wurmus
2018-01-20 11:29         ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7xa6o71.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=29896@debbugs.gnu.org \
    --cc=boskovits@gmail.com \
    --cc=cmmarusich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.