From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ediK5-0003Ii-Rx for guix-patches@gnu.org; Mon, 22 Jan 2018 15:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ediK2-0004ll-PL for guix-patches@gnu.org; Mon, 22 Jan 2018 15:04:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58853) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ediK2-0004lh-K2 for guix-patches@gnu.org; Mon, 22 Jan 2018 15:04:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ediK2-00066t-7k for guix-patches@gnu.org; Mon, 22 Jan 2018 15:04:02 -0500 Subject: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0. Resent-Message-ID: References: <20171229190022.22705-1-boskovits@gmail.com> <20180107212356.18556-1-boskovits@gmail.com> <87efmmtky1.fsf@gmail.com> <87y3kuf9u1.fsf@gmail.com> From: Ricardo Wurmus In-reply-to: <87y3kuf9u1.fsf@gmail.com> Date: Fri, 19 Jan 2018 13:13:54 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87a7xa6o71.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits , 29896@debbugs.gnu.org Chris Marusich writes: > G=C3=A1bor Boskovits writes: > >> Actually I did forget to check if it is used runtime. >> It is used to build and OSGi bundle. >> At first I tried to fake the dependency like for the ant tasks, >> but I got compilation errors. > > If the new input is also required at runtime, then I'm not sure this > package definition is correct. I would normally expect a "runtime > dependency" to be either retained as a reference in the output, or > declared as a propagated-input (so that it gets installed alongside this > package when this package is installed into a profile). Perhaps I am > missing some information here. > > I'm hoping Ricardo can comment on how this is intended to work for Java > packages, since he originally added the ant-build-system. The jars that the ant-build-system generates are uncompressed and thus allow the scanner to find embedded store references. The problem seems to be that references to other *jars* are not kept, because they are never recorded anywhere. That=E2=80=99s normal for Java, which looks for n= amed classes on the classpath, i.e. a list of jars. It behaves very much like Python and its PYTHONPATH in this regard. The best we can do here is to propagate inputs. The alternative is to try to be smart and record the effective runtime classpath, but that=E2=80= =99s hard/impossible to get right. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net