all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Joe Hillenbrand <joehillen@gmail.com>
Cc: 32933@debbugs.gnu.org
Subject: [bug#32933] [PATCH] guix: add license prefix hackage imports
Date: Fri, 12 Oct 2018 22:31:05 +0200	[thread overview]
Message-ID: <87a7nioqk6.fsf@elephly.net> (raw)
In-Reply-To: <CANJQ5C5PfMfM4dduVEiqnT36x_9ZpCQKN7DZtWGr2UHYA3EWDA@mail.gmail.com>


Hi Joe,

> The motivation was to be consistent with the `gnu/packages/haskell.scm` which
> uses the `license:` prefix. I noticed this when I imported a bunch of packages
> and all of them were missing the prefix, which then had to be manually added.
>
> On Fri, Oct 12, 2018 at 6:17 AM Ludovic Courtès <ludo@gnu.org> wrote:
>>
>> No strong opinion, but apparently none of the importers currently adds
>> the ‘license:’ prefix and I’d rather keep that consistent, one way or
>> another.
>
> That's not entirely true. crate calls `spdx-string->license` which adds the
> prefix, but it doesn't appear to actually work because it looks for the license
> in the wrong part of the json output from crates.io.

I have a slight preference to not adding the prefix.  It is true that
most modules do use this prefix, but I think the importers should be
agnostic of that.  Some modules don’t use this prefix (e.g. web.scm) or
no prefix at all (especially user modules that don’t exist yet).

I’d rather have the importers be more flexible and do the right thing
dependent on context, but I have no good idea how to accomplish this
considering that they are used outside of any context (unless they were
called as part of an updater).

--
Ricardo

  reply	other threads:[~2018-10-12 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 16:17 [bug#32933] [PATCH] guix: add license prefix hackage imports Joe Hillenbrand
2018-10-12 13:17 ` Ludovic Courtès
2018-10-12 17:55   ` Joe Hillenbrand
2018-10-12 20:31     ` Ricardo Wurmus [this message]
2018-10-15  8:07       ` Ludovic Courtès
2018-10-15  9:47         ` Ricardo Wurmus
2018-10-15 13:42           ` Joe Hillenbrand
2018-10-15 13:47             ` Ricardo Wurmus
2021-12-21 17:18 ` bug#32933: " Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7nioqk6.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=32933@debbugs.gnu.org \
    --cc=joehillen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.