From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gB46Q-0002Vx-0Z for guix-patches@gnu.org; Fri, 12 Oct 2018 16:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gB46M-0006U0-0C for guix-patches@gnu.org; Fri, 12 Oct 2018 16:32:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gB46L-0006Tf-Ry for guix-patches@gnu.org; Fri, 12 Oct 2018 16:32:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gB46L-0006ey-Ks for guix-patches@gnu.org; Fri, 12 Oct 2018 16:32:01 -0400 Subject: [bug#32933] [PATCH] guix: add license prefix hackage imports Resent-Message-ID: References: <87h8hri9sj.fsf@gnu.org> From: Ricardo Wurmus In-reply-to: Date: Fri, 12 Oct 2018 22:31:05 +0200 Message-ID: <87a7nioqk6.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Joe Hillenbrand Cc: 32933@debbugs.gnu.org Hi Joe, > The motivation was to be consistent with the `gnu/packages/haskell.scm` w= hich > uses the `license:` prefix. I noticed this when I imported a bunch of pac= kages > and all of them were missing the prefix, which then had to be manually ad= ded. > > On Fri, Oct 12, 2018 at 6:17 AM Ludovic Court=C3=A8s wrote: >> >> No strong opinion, but apparently none of the importers currently adds >> the =E2=80=98license:=E2=80=99 prefix and I=E2=80=99d rather keep that c= onsistent, one way or >> another. > > That's not entirely true. crate calls `spdx-string->license` which adds t= he > prefix, but it doesn't appear to actually work because it looks for the l= icense > in the wrong part of the json output from crates.io. I have a slight preference to not adding the prefix. It is true that most modules do use this prefix, but I think the importers should be agnostic of that. Some modules don=E2=80=99t use this prefix (e.g. web.scm= ) or no prefix at all (especially user modules that don=E2=80=99t exist yet). I=E2=80=99d rather have the importers be more flexible and do the right thi= ng dependent on context, but I have no good idea how to accomplish this considering that they are used outside of any context (unless they were called as part of an updater). -- Ricardo