[bug#40307] gnu: packages: telephony: Add spandsp

[bug#40307] gnu: packages: telephony: Add spandsp

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]

Hello Guix!

Please find the attached patch to add "spandsp" package.

Regards,
RG.

[-- Attachment #2: spandsp.patch --]
[-- Type: application/octet-stream, Size: 2014 bytes --]

From 68e093007f2c5678895a5cbe29f2b1ac2c357ba2 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 28 Mar 2020 23:32:57 -0400
Subject: [PATCH 13/13] gnu: packages: telephony: Add spandsp

* gnu/packages/telephony.scm (spandsp): New variable.
---
 gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index fe6c230693..c68f80669c 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -52,6 +52,7 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages libcanberra)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages multiprecision)
@@ -84,6 +85,35 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system qt))
 
+(define-public spandsp
+ (package
+  (name "spandsp")
+  (version "0.0.6")
+  (source
+   (origin
+    (method url-fetch)
+    (uri
+     (string-append "https://www.soft-switch.org/downloads/" name "/"
+                    name "-" version ".tar.gz"))
+    (sha256
+     (base32 "0rclrkyspzk575v8fslzjpgp4y2s4x7xk3r55ycvpi4agv33l1fc"))))
+ (build-system gnu-build-system)
+ (native-inputs
+  `(("libtiff" ,libtiff)
+    ("zlib" ,zlib)))
+ (synopsis "DSP library for telephony")
+ (description "SpanDSP is a library of DSP functions for telephony, in the 8000 sample
+per second world of E1s, T1s, and higher order PCM channels.  It contains low level
+functions, such as basic filters.  It also contains higher level functions, such as
+cadenced supervisory tone detection, and a complete software FAX machine.")
+ (home-page "https://www.soft-switch.org/index.html")
+ (license
+  (list
+   ;; For Library
+   license:lgpl2.1+
+   ;; For Test Suites and Support Programs
+   license:gpl2+))))
+
 (define-public commoncpp
   (package
    (name "commoncpp")
-- 
2.26.0

[bug#40307] gnu: packages: telephony: Add spandsp

[Maxim Cournoyer]

Hello again :-)

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.
>
> From 68e093007f2c5678895a5cbe29f2b1ac2c357ba2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Sat, 28 Mar 2020 23:32:57 -0400
> Subject: [PATCH 13/13] gnu: packages: telephony: Add spandsp

This prefix also need to be adjusted to just "gnu: Add ...".

> * gnu/packages/telephony.scm (spandsp): New variable.
> ---
>  gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index fe6c230693..c68f80669c 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -52,6 +52,7 @@
>    #:use-module (gnu packages gnome)
>    #:use-module (gnu packages gnupg)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)
>    #:use-module (gnu packages libcanberra)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages multiprecision)
> @@ -84,6 +85,35 @@
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system qt))
>  
> +(define-public spandsp
> + (package
> +  (name "spandsp")
> +  (version "0.0.6")
> +  (source
> +   (origin
> +    (method url-fetch)
> +    (uri
> +     (string-append "https://www.soft-switch.org/downloads/" name "/"
> +                    name "-" version ".tar.gz"))
> +    (sha256
> +     (base32 "0rclrkyspzk575v8fslzjpgp4y2s4x7xk3r55ycvpi4agv33l1fc"))))
> + (build-system gnu-build-system)

The check phase doesn't seem to run anything; it just passes.  Perhaps
we don't start it the correct way?

> + (native-inputs
> +  `(("libtiff" ,libtiff)
> +    ("zlib" ,zlib)))
> + (synopsis "DSP library for telephony")
> + (description "SpanDSP is a library of DSP functions for telephony, in the 8000 sample
> +per second world of E1s, T1s, and higher order PCM channels.  It contains low level
> +functions, such as basic filters.  It also contains higher level functions, such as
> +cadenced supervisory tone detection, and a complete software FAX
> machine.")

This body of text is a bit too wide.  We limit our column width at 80
characters.  You can use M-q in Emacs to automatically re-flow the
paragraph.  I kind of like the concise description from Debian, because
it gives me a better idea of what the package can be used for: "SpanDSP
is a low-level signal processing library that modulate and demodulate
signals commonly used in telephony, such as the "noise" generated by a
fax modem or DTMF touchpad."

> + (home-page "https://www.soft-switch.org/index.html")
> + (license
> +  (list
> +   ;; For Library
> +   license:lgpl2.1+
> +   ;; For Test Suites and Support Programs
> +   license:gpl2+))))
> +

My preferred style for formatting the license list would be:

    (license (list license:lgpl2.1+  ;for the library
                   license:gpl2+)))) ;for the test suites and support programs


The indentation of the package is off.  Please use Emacs or the
indent-code.el script :-).

Maxim

[bug#40307] gnu: packages: telephony: Add spandsp

[Maxim Cournoyer]

Hi again,

I forgot to add; Debian adds the --enable-doc --enable-tests flags.  I
think it'd be nice to have a manpage, and perhaps the check phase would
actually run something with the above?

Maxim

[bug#40307] Alternative Source for TarBall

[Raghav Gururajan]

https://disroot.org/upload/BSso1ApOLdASSoZ3/spandsp-0.0.6.tar.gz

[bug#40307] Alternative Source for TarBall

[Raghav Gururajan]

> https://disroot.org/upload/BSso1ApOLdASSoZ3/spandsp-0.0.6.tar.gz

PROPER:

https://web.archive.org/web/20180626203108/https://www.soft-switch.org/downloads/spandsp/spandsp-0.0.6.tar.gz

bug#40307: gnu: packages: telephony: Add spandsp

[Maxim Cournoyer]

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.

Hi Raghav!

I've modified the package to add the doc + tests and pushed as
d82539d35f.

Thank you!

Closing.

[bug#40307] gnu: Add spandsp (v2)

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: spandsp-v2.patch --]
[-- Type: application/octet-stream, Size: 5821 bytes --]

From f2e8b2ebcd7edc0e8f15f6c8b676a063e1e50983 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Wed, 1 Apr 2020 23:57:39 -0400
Subject: [PATCH 19/19] gnu: Add spandsp

* gnu/packages/telephony.scm (spandsp): New variable.
---
 gnu/packages/telephony.scm | 96 +++++++++-----------------------------
 1 file changed, 22 insertions(+), 74 deletions(-)

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index 9c2c499ed7..1365fb997c 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -99,87 +99,35 @@
      (origin
        (method url-fetch)
        (uri
-        ;; The original upstream has been down since the end of March 2020.
-        (string-append "https://web.archive.org/web/20180626203108/"
-                       "https://www.soft-switch.org/downloads/" name "/"
+        (string-append "https://www.soft-switch.org/downloads/" name "/"
                        name "-" version ".tar.gz"))
        (sha256
         (base32 "0rclrkyspzk575v8fslzjpgp4y2s4x7xk3r55ycvpi4agv33l1fc"))))
     (build-system gnu-build-system)
-    (outputs '("out" "doc" "static"))   ;doc contains HTML documentation
     (arguments
-     `(#:configure-flags '("--enable-doc=yes" "--enable-tests=yes")
-       #:parallel-tests? #f ;fails removing the same the files twice otherwise
-       #:phases (modify-phases %standard-phases
-                  (add-after 'unpack 'patch-configure.ac
-                    (lambda _
-                      ;; spandsp looks at hard coded locations of the FHS to
-                      ;; find libxml2.
-                      (substitute* "configure.ac"
-                        (("AC_MSG_CHECKING\\(for libxml/xmlmemory\\.h.*" all)
-                         (string-append all
-                                        "PKG_CHECK_MODULES(XML2, libxml-2.0)\n"
-                                        "CPPFLAGS+=\" $XML2_CFLAGS\"\n")))
-                      ;; Force a regeneration of the autotools build system.
-                      (delete-file "autogen.sh")
-                      (delete-file "configure")
-                      #t))
-                  (add-after 'unpack 'do-not-install-data-files
-                    ;; The .tiff images produced for tests are not
-                    ;; reproducible and it is not desirable to have those
-                    ;; distributed.
-                    (lambda _
-                      (substitute* '("test-data/itu/fax/Makefile.am"
-                                     "test-data/etsi/fax/Makefile.am")
-                        (("nobase_data_DATA")
-                         "noinst_DATA"))
-                      #t))
-                  (add-after 'install 'install-doc
-                    (lambda* (#:key outputs #:allow-other-keys)
-                      (let ((doc (string-append (assoc-ref outputs "doc")
-                                                "/share/doc/" ,name "-" ,version)))
-                        (copy-recursively "doc/t38_manual" doc)
-                        #t)))
-                  (add-after 'install 'move-static-libraries
-                    (lambda* (#:key outputs #:allow-other-keys)
-                      (let ((out (assoc-ref outputs "out"))
-                            (static (assoc-ref outputs "static")))
-                        (mkdir-p (string-append static "/lib"))
-                        (with-directory-excursion out
-                          (for-each (lambda (file)
-                                      (rename-file file
-                                                   (string-append static "/"
-                                                                  file)))
-                                    (find-files "lib" "\\.a$")))
-                        #t))))))
+     `(#:configure-flags
+       (list
+        "--disable-static")             ; Not required
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'check))))             ; Not required
     (native-inputs
-     `(("autoconf" ,autoconf)
-       ("automake" ,automake)
-       ("libtool" ,libtool)
-       ("pkg-config" ,pkg-config)
-       ;; For the tests
-       ("fftw" ,fftw)
-       ("libpcap" ,libpcap)
-       ("libsndfile" ,libsndfile)
-       ("libtiff" ,libtiff)
-       ("netpbm" ,netpbm)
-       ("sox" ,sox)
-       ;; For the documentation
-       ("docbook-xml" ,docbook-xml-4.3)
-       ("docbook-xsl" ,docbook-xsl)
-       ("doxygen" ,doxygen)
-       ("libxml2" ,libxml2)
-       ("libxslt" ,libxslt)))
+     `(("zlib" ,zlib)))
+    (propagated-inputs
+     `(("libtiff" ,libtiff)))
     (synopsis "DSP library for telephony")
-    (description "SpanDSP is a library of DSP functions for telephony, in the
-8000 sample per second world of E1s, T1s, and higher order PCM channels.  It
-contains low level functions, such as basic filters.  It also contains higher
-level functions, such as cadenced supervisory tone detection, and a complete
-software FAX machine.")
-    (home-page "https://web.archive.org/web/20180626203108/\
-https://www.soft-switch.org/index.html")
-    (license (list license:lgpl2.1+  ;for the library
-                   license:gpl2+)))) ;for the test suites and support programs
+    (description "SpanDSP is a library of DSP functions for telephony,
+in the 8000 sample per second world of E1s, T1s, and higher orderPCM channels.
+It contains low level functions, such as basic filters.  It also contains
+higher level functions, such as cadenced supervisory tone detection, and a
+complete software FAX machine.")
+    (home-page "https://www.soft-switch.org/index.html")
+    (license
+     (list
+      ;; For Library
+      license:lgpl2.1+
+      ;; For Test Suites and Support Programs
+      license:gpl2+))))
 
 (define-public commoncpp
   (package
-- 
2.26.0