From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Soo <jsoo1@asu.edu>
Cc: 40301@debbugs.gnu.org
Subject: [bug#40301] [PATCH] Fixed some issues with the patches.
Date: Sat, 11 Apr 2020 21:55:36 +0200 [thread overview]
Message-ID: <87a73h3ih3.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87o8ryq9h4.fsf@asu.edu> (John Soo's message of "Sat, 11 Apr 2020 09:21:27 -0700")
Hello,
John Soo <jsoo1@asu.edu> writes:
> I rebased these commits on master, moved the build-system field up, and
> put the sha string on the same line as base32. I also moved the
> definition further up in the file to avoid conflicts.
Thank you!
> +(define-public emacs-psc-ide
> + (package
> + (name "emacs-psc-ide")
> + (version "0.0.0")
According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,
you need to add a revision number, "0", or "1" at this point.
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/purescript-emacs/psc-ide-emacs")
> + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))
The commit should be moved in a top-level `let' at the beginning of the
package definition.
> + (file-name (git-file-name name "0.0.0"))
This should use version, along with the revision number.
> + (synopsis "Emacs integration for PureScript's psc-ide tool")
> + (description
> + "Emacs integration for PureScript's psc-ide tool. Featuring:
Description should be made of full sentences. Also, it might be useful
to explain what "psc-ide" tool is.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-04-11 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 1:11 [bug#40301] [PATCH] gnu: Add emacs-psc-ide John Soo
2020-04-11 16:21 ` [bug#40301] [PATCH] Fixed some issues with the patches John Soo
2020-04-11 19:55 ` Nicolas Goaziou [this message]
2020-04-12 0:45 ` John Soo
2020-04-12 9:04 ` bug#40301: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a73h3ih3.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=40301@debbugs.gnu.org \
--cc=jsoo1@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.